Update according to TODO #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves compute-io/todo#40
NOTE: breaking change.
add
no longer mutates by default. This behavior must be explicitly set using thecopy
option. While memory management is important, three factors contribute to turning off mutation by default:arrays
, mutation has a side-effect that object elements are eliminated and replaced with numeric results. For more complex objectarrays
, this is unlikely to be desired. Setting{'copy':true}
for each invocation is probably more than should be asked.add( x, y, {'copy': false})
means that the code is explicit in describing the behavior. If I understand that thecopy
option pertains to mutation, then I derive meaning from the signature.