Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension flags, location in scheduleItem and color in DimensionValue #484

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

japsu
Copy link
Contributor

@japsu japsu commented Apr 22, 2024

Changes to the GraphQL API:

  1. The following fields are added in ProgramType:
  • isMultiValue – Suggests to UI that this dimension is likely to have multiple values selected.
  • isListFilter – Suggests to UI that this dimension should be shown as a list filter
  • isShownInDetail – Suggests to UI that this dimension should be shown in detail view.
  • isNegativeSelection – Suggests to UI that when this dimension is not being filtered on, all values should be selected.
  1. The location field is added in ScheduleItemType.
  • location still exists on ProgramType for convenience, but using it is strongly discouraged in favour of ScheduleItemType.location as schedule items may (in the future) be in different locations.
  1. The color field is added in DimensionValueType and ProgramType.
  • The color of the program is selected arbitrarily (likely first one created in DB) if several of its dimension values try to specify a color.

The Program Guide V2 Light makes use of ProgramType.color now as follows:

image

@japsu japsu force-pushed the feat/program-v2-dimension-flags branch from 4c2c809 to f99f2cc Compare May 22, 2024 18:52
@japsu japsu force-pushed the feat/program-v2-dimension-flags branch 3 times, most recently from 7345afa to b70d090 Compare June 1, 2024 13:44
@japsu japsu changed the title wip(program_v2): dimension flags Dimension flags, location in scheduleItem and color in DimensionValue Jun 1, 2024
@japsu japsu force-pushed the feat/program-v2-dimension-flags branch from b70d090 to 4a84c1f Compare June 1, 2024 13:59
@japsu japsu marked this pull request as ready for review June 1, 2024 14:00
@japsu japsu merged commit 1a224b5 into main Jun 1, 2024
8 checks passed
@japsu japsu deleted the feat/program-v2-dimension-flags branch June 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant