-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yaml-cpp: fix msvc shared + modernize #10633
yaml-cpp: fix msvc shared + modernize #10633
Conversation
This PR has broken compilation on MacOS Upd. Maybe I need a newer conan>=1.45.0. Will check Full error:
|
@SergeyKrivohatskiy |
@uilianries Yep. Checked that already. Will leave the message anyway in case someone will face the same issue. Thanks |
The problem is that imports are evaluated before conan check of |
@SpaceIm Excellent observation! Thank you for pointing it on Conan client. |
functools.lru_cache
is_msvc()
&is_msvc_static_runtime()
instead of custom methodsYAML_CPP_DLL
interface definition if msvc & shared to properly define__declspec(dllimport)
at consume time, since yaml-cpp has several global symbols.closes #10629