Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watcher: add version 0.9.2, remove older versions #19512

Merged
merged 12 commits into from
Sep 28, 2023
Merged

watcher: add version 0.9.2, remove older versions #19512

merged 12 commits into from
Sep 28, 2023

Conversation

toge
Copy link
Contributor

@toge toge commented Aug 31, 2023

Specify library name and version: watcher/*

  • watcher support C++17 since 0.9.0
  • API is changed in 0.9.0

@toge toge changed the title watcher: add version 0.9.0, remove older versions, watcher: add version 0.9.0, remove older versions, Aug 31, 2023
@toge toge changed the title watcher: add version 0.9.0, remove older versions, watcher: add version 0.9.0, remove older versions Aug 31, 2023
@prince-chrismc prince-chrismc mentioned this pull request Aug 31, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Aug 31, 2023
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier ericLemanissier mentioned this pull request Sep 2, 2023
Closed
AbrilRBS
AbrilRBS reviewed Sep 2, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A question about the new patch :)

recipes/watcher/all/patches/0.9.0-include-atomic.patch Outdated

#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2, 7, 0)) || defined(__ANDROID_API__)

+#include <atomic>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been reported upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS
Not yet.
I found several problems about new release.
I am checking these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toge I see that you contributed to Watcher project already! Thank you so much for doing it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries
Watcher has been updated to 0.9.2 with fixing this issue.
I deleted this patch.

Please review it again.

@AbrilRBS AbrilRBS self-assigned this Sep 2, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@toge toge changed the title watcher: add version 0.9.0, remove older versions watcher: add version 0.9.2, remove older versions Sep 11, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (32693d2066887eee295c39833176cf4761401c69):

  • watcher/0.5.5:
    All packages built successfully! (All logs)

  • watcher/0.8.7:
    All packages built successfully! (All logs)

  • watcher/0.6.0:
    All packages built successfully! (All logs)

  • watcher/0.8.8:
    All packages built successfully! (All logs)

  • watcher/0.4.3:
    All packages built successfully! (All logs)

  • watcher/0.8.0:
    All packages built successfully! (All logs)

  • watcher/0.5.4:
    All packages built successfully! (All logs)

  • watcher/0.5.2:
    All packages built successfully! (All logs)

  • watcher/0.9.2:
    All packages built successfully! (All logs)

@e-dant
Copy link

e-dant commented Sep 16, 2023 •
edited
Loading

Hi all -- Thank you again for your work on this project

uilianries
uilianries approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saukijan saukijan mentioned this pull request Sep 21, 2023
Closed
@conan-center-bot conan-center-bot merged commit 328d8a0 into conan-io:master Sep 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toge @conan-center-bot @e-dant @uilianries @AbrilRBS