Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opengl: don't fail hard when distro is unknown #2114

Merged
merged 1 commit into from Jul 14, 2020

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jul 3, 2020

Specify library name and version: opengl/system

without this change, all unknown distribution have a hard fail with

opengl/system: WARN: Don't know how to install OpenGL for your distro.
opengl/system: ERROR: while executing system_requirements(): local variable 'packages' referenced before assignment
ERROR: Error in system requirements
  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (71bb5df29631efe01f13acb113b4d2202bc32a6a)! 😊

@SSE4 SSE4 requested review from danimtb and uilianries July 3, 2020 15:10
@ericLemanissier
Copy link
Contributor Author

@jgsogo WDYT of this PR ?
Without it we have unavoidable hard failures on some distros: https://github.com/bincrafters/conan-qt/runs/866169432?check_suite_focus=true#step:10:523

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to fail for an unknown distro, let's do it, but not because a variable is not defined 👍

@jgsogo jgsogo merged commit 509d9c6 into conan-io:master Jul 14, 2020
@ericLemanissier ericLemanissier deleted the patch-1 branch July 14, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants