add Open62541 recipe v1.0.3 and v1.1.3 #3786

saukijan · 2020-12-03T14:34:14Z

Description

as @prince-chrismc recommended in his comment, I am refactoring my work from PR #1687 with the work @syoliver did in PR #1856 to hopefully bring the best of both worlds and finally release the definative Open62541 recipe.

This PR:

uses pro-mdnsd/0.8.4 as a conan dependency instead of git sub-module.
uses a slightly reduced option set (not all Open62541 are used in this recipe) to improve package usability and stability.
uses UA-Nodeset git sub-module as it is required for Non-minimal setups (conan option namespace_zero is not set to MINIMAL).

I could create a separate conan package for this, however UA-Nodeset project contains meta information for OPC UA standard (xml files that describe various data models) and I personally do not think that this sort of package would be relevant for conan-center-index, though I am interested to hear the thoughts of conan-io community on this topic.

provides support for both v1.0.x and v1.x.x releases, since both are used by the community.
closes Add open62541/1.1 #1856
closes add open62541 recipe for v1.0 and v1.0.1 #1687

Questions to conan-io communtiy:

Would you prefer @syoliver way of writing a test_package for both client and server symbols, or a more simplified test_package?
Would a separate UA-Nodeset package containing only meta information be a relevant addition to conan-center-index repository?

To Do:

Test standard options for v1.0.3
Test standard options for v1.1.3
Test all option variations for v1.0.3
Test all option variations for v1.1.3
Update official documentation PR #3659

Specify library name and version: open62641/1.0.3 and open62641/1.1.3

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

…figs Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

…options Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

conan-center-bot · 2020-12-07T15:20:29Z

Some configurations of 'open62541/1.1.3' failed in build 23 (e7a7306cfb839e86b4ea510ff703df92d54a3785):

Linux x86_64, Release, clang 9, libstdc++ . Options: open62541:shared-False
Access to all the logs
Linux x86_64, Debug, clang 9, libstdc++ . Options: open62541:shared-False
Access to all the logs
Linux x86_64, Debug, clang 9, libstdc++ . Options: open62541:shared-True
Access to all the logs
Linux x86_64, Release, clang 9, libstdc++ . Options: open62541:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MT. Options: open62541:shared-False
Access to all the logs

…ckets, set hardening to True remove clang 9 support

saukijan · 2020-12-07T17:03:56Z

Option testing report

I finished testing both v1.0.3 and v1.1.3 packages with all of the options enabled (I ran separate tests for each encryption, multi-threading and pub sub option with other options set to True) and it works on my Linux debian 9 machine with GCC 8 compiler. Of course, I can not guaranty that each option permutation with various operating systems and compilers will work since I did not set up any automation to test all of these variables nor did I test all of it by hand for obvious reasons.

From my point of view if all options work on the same time, there is no reason why they should not work on there own, since all of the options that require something else are already handle during the configuration, but again no guaranty...

Regarding Clang 9 support

I tried my hardest to get rid of error: unused parameter both with -Qunused-arguments and -Wno-unused-command-line-argument but it does not seem to work, if anyone knows how to disable this check without disabling -Werror as well let me know and I will patch it in!

Edit 2020.12.10

It seems that I have mixed up the reports between 1.0.3 and 1.1.3. -Wno-unused-command-line-argument works for v1.1.3 releases due to a different flag handling mehcanism

Regarding Cpp compatibility support for 1.0.3

I removed it due to the fact that I would have to patch quite a bit of source files to get rid of Error: Jump to case label. from -fpermissive. I have patched it in the past as well as did a PR for this issue with open62541, but someone keeps adding code with goto calls everywhere...

conan-center-bot · 2020-12-07T17:15:04Z

Some configurations of 'open62541/1.1.3' failed in build 24 (0ef82e483e7fd21c6566cdbac797b4fdf95a7b0c):

Linux x86_64, Release, clang 8, libstdc++ . Options: open62541:shared-True
Access to all the logs

conan-center-bot · 2020-12-07T17:54:58Z

Some configurations of 'open62541/1.1.3' failed in build 25 (f38dd369617aa9ba4a88880081e5671d39943577):

Linux x86_64, Release, clang 8, libstdc++ . Options: open62541:shared-True
Access to all the logs

conan-center-bot · 2020-12-09T19:19:44Z

All green in build 26 (8b2a79cda42515b5de6cfb335db1cee55180ee42)! 😊

open62541/1.0.3: Generated 76 packages. All logs here
open62541/1.1.3: Generated 80 packages. All logs here

jgsogo

Some comments about some <= signs, not sure if they should be < according to the messages in the ConanInvalidConfiguration errors. 🤔

recipes/open62541/all/conanfile.py

…irname(__file__)

conan-center-bot · 2020-12-10T10:10:40Z

Some configurations of 'open62541/1.0.3' failed in build 27 (8718bc1f2433e6c7e9469f79c569349821121544):

Linux x86_64, Release, clang 4.0, libstdc++ . Options: open62541:shared-False
Access to all the logs
Linux x86_64, Debug, clang 4.0, libstdc++ . Options: open62541:shared-False
Access to all the logs

conan-center-bot · 2020-12-10T15:03:29Z

All green in build 28 (c15446ecc7f2c07387c03e681b7ab92d81fe6c28)! 😊

open62541/1.0.3: Generated 76 packages. All logs here
open62541/1.1.3: Generated 80 packages. All logs here

* master: (73 commits) (conan-io#3878) opengl: support FreeBSD (conan-io#3882) [system-cci] Fix hooks (conan-io#3881) [szip] Fix hooks (conan-io#3880) [tcl] Fix hooks (conan-io#3866) xorg: add freebsd packages (conan-io#3825) Adds baikal-p7 5.6 (conan-io#3758) minimal recipe for pciutils/3.7.0 (conan-io#3211) added recipe for extra-cmake-modules (conan-io#3870) tl: fix compiler version check again (conan-io#3865) bump eigen/3.3.9 (conan-io#3864) add functionalplus/0.2.13-p0 bump fmt/7.1.3 (conan-io#3694) (conan-io#3858) fix: zulu-openjdk package info (conan-io#3836) gmp: bump + enable building static libraries on MSVC (conan-io#3812) Add logr v0.1.0 (conan-io#3786) add Open62541 recipe v1.0.3 and v1.1.3 (conan-io#3696) openh264: refactor + add 2.1.1 release (conan-io#3607) add botan/2.17.2 (conan-io#3854) Add PEGTL 3.0.0 (conan-io#3859) bump spdlog/1.8.2 ...

saukijan added 30 commits December 3, 2020 10:32

add open62541 recipe for v1.0 and v1.0.1

a2ac5da

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

fix package versioning

98a1e39

fix fPIC managment for Windows

29f1e5d

remove AddSan flags for Debug setup with Clang

a369bc6

change integration test to be more generic

402ca72

remove stringify macro for default config plugin

de18a1c

remove pthread from test_package CMakeLitsts.txt

85ffd21

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

merge set_static_version v1.0 and v1.0.1 into one patch

4e13af7

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

set project version from recipe

e686498

rework integration test to use cpp threads

54f9f60

add cpp11 flag for test_package

7145978

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

add win32 includes and links

648317e

add copy open62541.dll into lib directory step for windows shared con…

6402633

…figs Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

fixed cmake install for windows systems

82831a6

remove license exporting

28a7f33

revert license removal from package

47f830e

add loging level selection

589b881

change .dll packaging location from lib/ to bin/

bc268f5

change json_support default value to False

126d2aa

change namescpae_zero defautl value to FULL

50837e8

fix alogging level typo

30ffa79

add conditional requirement

85d8ba5

add shared lib condition to set fPIC option

2172859

remove support for static clang configurations

ca5fa53

remove setting BUILD_SHARED_LIBS and POSITION_INDEPENDENT_CODE cmake …

4146aa1

…options Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

fix singe_header option

449e575

Signed-off-by: Dovydas Girdvainis <dovydas.girdvainis@hahn-schickard.de>

remove multithreading support for v1.0.0

fbc0f98

change default value for data access to true

fdd029a

remove exporting multithreading definition

cbe5809

fix option typos

7706bd9

saukijan added 2 commits December 7, 2020 17:29

fix cmake module path, find_package lib names, libwebsockets linking

b7ecb9f

change "None" options to False, forward encryption option to libwebos…

0ef82e4

…ckets, set hardening to True remove clang 9 support

remove -Qunused-arguments compiler argument

f38dd36

saukijan added 2 commits December 8, 2020 09:57

add -Wno-unused-command-line-argument to patch

a7b9cb7

re-enable clang 9 support for 1.1.3

8b2a79c

conan-center-bot removed the Failed label Dec 9, 2020

jgsogo reviewed Dec 10, 2020

View reviewed changes

recipes/open62541/all/conanfile.py Outdated Show resolved Hide resolved

recipes/open62541/all/conanfile.py Outdated Show resolved Hide resolved

recipes/open62541/all/conanfile.py Outdated Show resolved Hide resolved

saukijan added 2 commits December 10, 2020 10:51

fix comparison operators, use self.recipe_folder instead of os.path.d…

9c5de64

…irname(__file__)

reduce integration test from 1 second to 1 milisecond

8718bc1

conan-center-bot added the Failed label Dec 10, 2020

remove clang 4 support and fix configuration message

c15446e

conan-center-bot removed the Failed label Dec 10, 2020

jgsogo approved these changes Dec 10, 2020

View reviewed changes

prince-chrismc approved these changes Dec 10, 2020

View reviewed changes

jgsogo requested a review from SSE4 December 11, 2020 07:49

SSE4 requested a review from uilianries December 13, 2020 17:45

SSE4 approved these changes Dec 13, 2020

View reviewed changes

conan-center-bot merged commit b011e7b into conan-io:master Dec 14, 2020

prince-chrismc mentioned this pull request Apr 25, 2021

Added yojimbo/1.2.1 recipe #5261

Merged

4 tasks

Ahajha mentioned this pull request Oct 18, 2023

open62541 recipe forbids clang > 9 #20579

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Open62541 recipe v1.0.3 and v1.1.3 #3786

add Open62541 recipe v1.0.3 and v1.1.3 #3786

saukijan commented Dec 3, 2020 •

edited

Loading

conan-center-bot commented Dec 7, 2020

saukijan commented Dec 7, 2020 •

edited

Loading

conan-center-bot commented Dec 7, 2020

conan-center-bot commented Dec 7, 2020

conan-center-bot commented Dec 9, 2020

jgsogo left a comment

conan-center-bot commented Dec 10, 2020

conan-center-bot commented Dec 10, 2020

add Open62541 recipe v1.0.3 and v1.1.3 #3786

add Open62541 recipe v1.0.3 and v1.1.3 #3786

Conversation

saukijan commented Dec 3, 2020 • edited Loading

Description

This PR:

Questions to conan-io communtiy:

To Do:

conan-center-bot commented Dec 7, 2020

saukijan commented Dec 7, 2020 • edited Loading

Option testing report

Regarding Clang 9 support

Regarding Cpp compatibility support for 1.0.3

conan-center-bot commented Dec 7, 2020

conan-center-bot commented Dec 7, 2020

conan-center-bot commented Dec 9, 2020

jgsogo left a comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 10, 2020

conan-center-bot commented Dec 10, 2020

saukijan commented Dec 3, 2020 •

edited

Loading

saukijan commented Dec 7, 2020 •

edited

Loading