Add librealsense/2.40.0 #3868
Add librealsense/2.40.0 #3868
Conversation
|
Some configurations of 'librealsense/2.40.0' failed in build 1 (
|
| cmake = self._configure_cmake() | ||
| cmake.install() | ||
| tools.rmdir(os.path.join(self.package_folder, "lib", "pkgconfig")) | ||
| tools.rmdir(os.path.join(self.package_folder, "lib", "cmake")) |
There was a problem hiding this comment.
Can you please explicitly set the cmake_find_package and pkg_config generator name in package_info?
Thanks
There was a problem hiding this comment.
| #include "l500-serializable.h" | ||
| -#include "../../../third-party/json.hpp" | ||
| +#include "../../third-party/json.hpp" | ||
|
|
There was a problem hiding this comment.
I have 2 questions about this:
- is this a bug in their code as the relative path is wrong
- what 3rd party json lib is used? Does conan have it already?
There was a problem hiding this comment.
I think it's the excessive use of PROJECT_SOURCE_DIR +> to realative path + the CCI cmake wrapper https://github.com/IntelRealSense/librealsense/search?q=PROJECT_SOURCE_DIR
Yes but we dont have anything old
https://github.com/IntelRealSense/librealsense/blob/34fc284d537a4b873a37b737a61f1f1da92dbb60/third-party/json.hpp#L4
There was a problem hiding this comment.
We have 3.4-3.9. I guess that's too recent and breaking the api?
There was a problem hiding this comment.
yep!
There are a lot of 3rd party that are embedded, I am not sure it thats a blocker 🚫
| - include(libusb_config) | ||
| - target_link_libraries(${LRS_TARGET} PRIVATE usb) | ||
| + find_package(libusb REQUIRED) | ||
| + target_link_libraries(${LRS_TARGET} PRIVATE libsusb) |
There was a problem hiding this comment.
If this is using a Conan cmake_find_package, then you're linking to a library instead of a library target
|
|
||
| set_target_properties (${PROJECT_NAME} PROPERTIES FOLDER Library) | ||
|
|
||
| +target_link_libraries(${PROJECT_NAME} Boost::Boost lz4::lz4) |
There was a problem hiding this comment.
FYI, conan's boost had components now so this is header only
| + target_link_libraries(${LRS_TARGET} PRIVATE libsusb) | ||
| if(USE_EXTERNAL_USB) | ||
| - add_dependencies(${LRS_TARGET} libusb) | ||
| + add_dependencies(${LRS_TARGET} libusb) |
There was a problem hiding this comment.
Since libusb is the lib.a there's no cmake target and there's no dependency
There was a problem hiding this comment.
Indeed, this does nothing. There is no other target to consider/build in the dependency tree.
| if self.settings.os != "Windows": | ||
| self.requires("libusb/1.0.23") |
There was a problem hiding this comment.
Why is libusb not needed on Windows?
Btw, the libusb library on Linux is libusb.a (so linkable in cmake by adding usb to target_link_libraries).
On MSV it is called libusb.lib, so there it should be target_link_libraries(... libusb).
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
librealsense/2.40.0