Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cityhash/cci.20130801 #5769

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jun 5, 2021

Specify library name and version: lib/1.0

It fails with Visual Studio, there is some weird issue with source file path.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jun 5, 2021

make[2]: Entering directory '/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/src'
source='/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src/city-test.cc' object='city-test.obj' libtool=no \
DEPDIR=.deps depmode=msvc7 /bin/sh /c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/depcomp \
/c/j/w/buildsinglereference@2/.conan/data/automake/1.16.3/_/_/package/3e48e69237f7f2196164383ef9dedf0f93cbf249/bin/share/automake-1.16/compile cl -nologo -DHAVE_CONFIG_H -I. -I/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src -I..   -I/c/j/w/buildsinglereference@2/.conan/data/libtool/2.4.6/_/_/package/df56c2b4f8e488bbd25eedb52fba643c7d59c97f/include -DNDEBUG  -O2 -Ob2 -MT -FS -EHsc -c -o city-test.obj `cygpath -w '/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src/city-test.cc'`
source='/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src/city.cc' object='city.lo' libtool=yes \
DEPDIR=.deps depmode=msvc7 /bin/sh /c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/depcomp \
/bin/sh ../libtool  --tag=CXX   --mode=compile /c/j/w/buildsinglereference@2/.conan/data/automake/1.16.3/_/_/package/3e48e69237f7f2196164383ef9dedf0f93cbf249/bin/share/automake-1.16/compile cl -nologo -DHAVE_CONFIG_H -I. -I/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src -I..   -I/c/j/w/buildsinglereference@2/.conan/data/libtool/2.4.6/_/_/package/df56c2b4f8e488bbd25eedb52fba643c7d59c97f/include -DNDEBUG  -O2 -Ob2 -MT -FS -EHsc -c -o city.lo /c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src/city.cc
libtool: compile:  /c/j/w/buildsinglereference@2/.conan/data/automake/1.16.3/_/_/package/3e48e69237f7f2196164383ef9dedf0f93cbf249/bin/share/automake-1.16/compile cl -nologo -DHAVE_CONFIG_H -I. -I/c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src -I.. -I/c/j/w/buildsinglereference@2/.conan/data/libtool/2.4.6/_/_/package/df56c2b4f8e488bbd25eedb52fba643c7d59c97f/include -DNDEBUG -O2 -Ob2 -MT -FS -EHsc -c -showIncludes /c/j/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src/city.cc -o city.obj
city.cc
c1xx: fatal error C1083: Cannot open source file: 'C:J:/w/buildsinglereference@2/.conan/data/cityhash/cci.20130801/_/_/build/7bd6f2c3d5c4e48a75805376b58cde753392f711/source_subfolder/src/city.cc': No such file or directory
make[2]: *** [Makefile:641: city.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
city-test.cc

@madebr Any idea on this issue? Compilation of city.cc is wrapped in libtool and fails (it seems to do something wrong with file path), while compilation of city-test.cc succeeds without libtool.

@madebr
Copy link
Contributor

madebr commented Jun 6, 2021

@madebr Any idea on this issue? Compilation of city.cc is wrapped in libtool and fails (it seems to do something wrong with file path), while compilation of city-test.cc succeeds without libtool.

Weird, configure.ac and the Makefile.am files don't use any fancy features.

 /c/users/maarten/.conan/data/automake/1.16.3/_/_/package/3e48e69237f7f2196164383ef9dedf0f93cbf249/bin/share/automake-1.16/compile cl -nologo -DHAVE_CONFIG_H -I. -I/c/users/maarten/.conan/data/cityhash/cci.20130801/_/_/build/3fb49604f9c2f729b85ba3115852006824e72cab/source_subfolder/src -I.. -DNDEBUG -O2 -Ob2 -MD -FS -EHsc -c /c/users/maarten/.conan/data/cityhash/cci.20130801/_/_/build/3fb49604f9c2f729b85ba3115852006824e72cab/source_subfolder/src/city.cc

fails, but

cl -nologo -DHAVE_CONFIG_H -I. -I/c/users/maarten/.conan/data/cityhash/cci.20130801/_/_/build/3fb49604f9c2f729b85ba3115852006824e72cab/source_subfolder/src -I.. -DNDEBUG -O2 -Ob2 -MD -FS -EHsc -c /c/users/maarten/.conan/data/cityhash/cci.20130801/_/_/build/3fb49604f9c2f729b85ba3115852006824e72cab/source_subfolder/src/city.cc

succeeds.
So wrapping cl with automake's compile script makes it fail (unix path is incorrectly converted to a windows path).

I think the problem is due to stacking the compile script twice:
libtool will use the compile script (or something similar) themself.
When changing the environment variables to

                env = {
                    "CC": "cl -nologo",
                    "CXX": "cl -nologo",
                    "LD": "link -nologo",
                    "AR": "{} lib".format(tools.unix_path(self.deps_user_info["automake"].ar_lib)),
                }

I got it building.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jun 6, 2021

Great, thanks !

@conan-center-bot
Copy link
Collaborator

All green in build 4 (dd7293d100151123a572bea42cbbed4b0de2adab):

  • cityhash/cci.20130801@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit c65e2e6 into conan-io:master Jun 8, 2021
@SpaceIm SpaceIm deleted the new/cityhash/cci.20130801 branch June 8, 2021 06:13
madebr pushed a commit to madebr/conan-center-index that referenced this pull request Jun 21, 2021
* add cityhash/cci.20130801

* fix msvc build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants