Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chaiscript #828

Merged
merged 3 commits into from
Apr 14, 2020
Merged

add chaiscript #828

merged 3 commits into from
Apr 14, 2020

Conversation

Garcia6l20
Copy link
Contributor

Specify library name and version: chaiscript/6.1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/chaiscript/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/chaiscript/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/chaiscript/all/conanfile.py Show resolved Hide resolved
recipes/chaiscript/all/conanfile.py Outdated Show resolved Hide resolved
recipes/chaiscript/all/CMakeLists.txt Show resolved Hide resolved
@uilianries
Copy link
Member

Hi @Garcia6l20 ! Thanks for your contribution. Please, take a look on the comments.

@Garcia6l20
Copy link
Contributor Author

Thanks for reviewing and accepting me in EAP.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If chaiscript project says "header-only", why do you need those libraries (stl_extra and chaiscript_stdlib) ?

recipes/chaiscript/all/conanfile.py Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@uilianries
Copy link
Member

You could add the option header_only which does not generate those modules.

@Garcia6l20
Copy link
Contributor Author

Please notice the interpreter will also being packaged in non header_only package

@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'chaiscript/6.1.0' failed in build 6 (5231c6fafe21813beff5d31d10e54545d3a5390c):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: chaiscript:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Linux does not contain artifacts with these extensions: ['a', 'so', 'sh', ''] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=Linux, compiler=gcc (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared' option did not contains any shared artifact (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H015)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@Garcia6l20
Copy link
Contributor Author

Should I remove header_only option if shared is specified or raise a ConanInvalidConfiguration ?

@Garcia6l20
Copy link
Contributor Author

Or just remove it, it's a non-sense in chaiscript case.
Header only + loadable modules

@conan-center-bot
Copy link
Collaborator

All green in build 7 (651ee88d8cb34a1188819cb43cb884d1a229aa66)! 😊

@Garcia6l20
Copy link
Contributor Author

Unrelated question: are you interrested in Boost.DI, are experimental libraries ok to be available on conan-center ?

@uilianries
Copy link
Member

Bincrafters already offers modular Boost, here in CCI we only have Boost package. Separated packages for Boost are really hard to be maintained/aligned, thus I don't think is a good idea. However, you can try it for Bincrafters.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@uilianries uilianries requested a review from SSE4 March 6, 2020 16:51
@uilianries uilianries closed this Mar 6, 2020
@uilianries uilianries reopened this Mar 6, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 9 (651ee88d8cb34a1188819cb43cb884d1a229aa66)! 😊

@jgsogo jgsogo merged commit 056341c into conan-io:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants