-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add c-blosc/1.17.1 #933
add c-blosc/1.17.1 #933
Conversation
All green in build 1 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do not apply that patch, use cmake_find_package instead. I've checked, it's working
- Check with the upstream about the snappy x c++ linker
- c-blosc doesn't export any cmake target, so don't rename any cmake taget.
recipes/c-blosc/all/patches/cmake-dependencies_and_install.patch
Outdated
Show resolved
Hide resolved
recipes/c-blosc/all/patches/cmake-dependencies_and_install.patch
Outdated
Show resolved
Hide resolved
@uilianries Did you check on linux? Blosc uses uppercase for lz4 and zstd. Using conan targets avoid to worry about cpp_info.name modifications in dependent recipes. |
@SpaceIm I run Linux by default. And it's working on my side. Could you detail what is happening when building there in your side? My current output running conanio/gcc9 docker image:
$ conan create . 1.17.1@ -o c-blosc:shared=True
Exporting package recipe
c-blosc/1.17.1 exports: File 'conandata.yml' found. Exporting it...
c-blosc/1.17.1 exports: Copied 1 '.yml' file: conandata.yml
c-blosc/1.17.1 exports_sources: Copied 1 '.txt' file: CMakeLists.txt
c-blosc/1.17.1 exports_sources: Copied 1 '.patch' file: cmake-dependencies_and_install.patch
c-blosc/1.17.1: The stored package has not changed
c-blosc/1.17.1: Exported revision: ebdb6fadfa10e141d52497f2c8ef3f2e
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=9
os=Linux
os_build=Linux
[options]
c-blosc:shared=True
[build_requires]
[env]
c-blosc/1.17.1: Forced build from source lz4/1.9.2: Already installed!
-- Build files have been written to: /home/conan/.conan/data/c-blosc/1.17.1///build/55f41fdbe1a745dbc12e3adf454ad3b77a6d6a30/build_subfolder
-- Build files have been written to: /home/conan/project/test_package/build/5af5be6f123f3269e4a48a0e26b2b397d1a0c3aa |
@uilianries I remember. I've checked again and it doesn't properly work on Windows. |
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
All green in build 2 (
|
@SpaceIm Thanks for you detailed explanation. |
All green in build 3 (
|
Specify library name and version: c-blosc/1.17.1
conan-center hook activated.
#621