Available folders in post_export hook #11643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jul 14, 2022
lasote
commented
Jul 14, 2022
lasote
commented
Jul 14, 2022
lasote
commented
Jul 14, 2022
| @@ -11,33 +11,53 @@ | |||
|
|
|||
| def pre_export(conanfile): | |||
| conanfile.output.info("Hello") | |||
| # TODO: To have the export_folder here needs a bit more deep refactoring | |||
There was a problem hiding this comment.
How bad is this? how is the pre_export supposed to work? it might need also the export_folder, right?
There was a problem hiding this comment.
pre_export hook probably shouldn't have access to the export folders? If it happens before the actual export, those folders are not even created. Maybe pre_export is intended to operate mostly in the user space?
There was a problem hiding this comment.
why not? I might need to export some files from hook before conan exports from recipe
There was a problem hiding this comment.
some ConanCenter example? And some example that cannot be done in the post_hook?
This was referenced Jul 15, 2022
memsharded
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: The
conanfile.export_folderandconanfile.export_sources_folderare now available in thepost_hook().Docs: omit