Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCVars uses compiler.update #15947

Merged
merged 1 commit into from
Mar 27, 2024
Merged

VCVars uses compiler.update #15947

merged 1 commit into from
Mar 27, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Mar 25, 2024 •
edited by czoido
Loading

Changelog: Fix: Make VCVars use the compiler.update to specify the toolset.
Docs: Omit

Close #15522

Note that the equivalent doesn't work easily with CMake Visual Studio generators

@memsharded memsharded added this to the 2.3.0 milestone Mar 25, 2024
This was referenced Mar 25, 2024
Merged
Closed
@memsharded memsharded requested a review from jcar87 March 26, 2024 08:28
jcar87
jcar87 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@czoido czoido merged commit dc9d971 into conan-io:develop2 Mar 27, 2024
2 checks passed
@memsharded memsharded deleted the fix/vcvars_update branch March 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcar87 jcar87 jcar87 approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

conan.tools.microsoft.VCVars generator does not follow settings.compiler.update
3 participants
@memsharded @jcar87 @czoido