Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exclude some deps from conan dependency graph #16083

Conversation

Bbox123
Copy link
Contributor

@Bbox123 Bbox123 commented Apr 15, 2024

Changelog: Feature: In graph html search bar now takes in multiple search patterns separated by commas.
Changelog: Feature: In graph html added 'filter packages' bar that takes in multiple search patterns separated by comma and hides filters them from graph.
Docs: Omit

Fixes #9303

Demonstration of modified search bar functionality:
chrome_uOWBBaqrOK

Demonstration of filter bar functionality:
chrome_ORugRtGWm6

Footnote:
Our group wanted to suggest a design change for the filter packages search bar. Our design would modify the filter bar to only begin filtering upon pressing the enter key (or perhaps a button) instead of doing it for every state change of the filter bar.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded added this to the 2.3.0 milestone Apr 15, 2024
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Bbox123 - Thanks for this improvement! 😁

I just added a commit to use "exclude" instead of "filter". It sounds less ambiguous to me.

@franramirez688 franramirez688 merged commit 11f7707 into conan-io:develop2 Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] exclude some deps from conan dependency graph
5 participants