Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache db: using single quotes for strings #16123

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Apr 22, 2024

Changelog: Fix: Solve sqlite3 issues in FreeBSD due to queries with double quotes.
Docs: Omit

fixes #16115

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for addressing this @ericLemanissier

I guess the packages_table.py and localdb.py suffers the same, might need same changes.

@memsharded memsharded added this to the 2.3.0 milestone Apr 22, 2024
@ericLemanissier
Copy link
Contributor Author

I cannot guarantee that this fix is complete and correct, but at least it fixes conan create invocations (tested at https://github.com/ericLemanissier/conan-center-index/actions/runs/8782395019/job/24096433822)

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks very much.

I have reviewed the code too, and it seems to be covering all occurrences.

@memsharded memsharded merged commit 93ce1ed into conan-io:develop2 Apr 22, 2024
2 checks passed
@ericLemanissier ericLemanissier deleted the patch-1 branch April 22, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] sqlite3.OperationalError: no such column
3 participants