Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing multiple negation patterns for --build #16327

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 23, 2024

Changelog: Feature: Allow multiple --build=missing:~pattern1 --build=missing:~pattern2 patterns.
Docs: Omit

Close #16323

for pattern in self._build_missing_excluded:
if ref_matches(conanfile.ref, pattern, is_consumer=False):
return False
return True # If it has not been excluded by the negated patterns, it is included
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch :)

@franramirez688 franramirez688 merged commit 9aae1d0 into conan-io:develop2 May 27, 2024
2 checks passed
@memsharded memsharded deleted the feature/build_mode_missing_multiple_negation branch May 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Multiple --build=missing:~foo does not work
3 participants