Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal for user/channel in local-recipes-index #16342

Merged
merged 2 commits into from
May 27, 2024
Merged

proposal for user/channel in local-recipes-index #16342

merged 2 commits into from
May 27, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 26, 2024 •
edited by czoido
Loading

Changelog: Fix: Allow "local-recipes-index" to conan list packages with custom user/channel.
Docs: Omit

Close #16331

@memsharded memsharded added this to the 2.4.0 milestone May 26, 2024
@memsharded memsharded marked this pull request as ready for review May 27, 2024 13:45
@memsharded
Copy link
Member Author

For some extra data: running with this change over all conan-center-index increases the response time from 2-3 seconds to around 7-9 seconds in my laptop. As listing the whole conan-center-index shouldn't be that common, and time is still acceptable, I think we are good moving this fix forward.

@czoido czoido merged commit 1ccbafb into conan-io:develop2 May 27, 2024
2 checks passed
@memsharded memsharded mentioned this pull request May 27, 2024
Closed
1 task
@memsharded memsharded deleted the fix/local_recipes_index_user_channel branch May 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franramirez688 franramirez688 franramirez688 approved these changes

@czoido czoido czoido approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

[question] Install from local recipes index with user/channel
4 participants
@memsharded @franramirez688 @czoido @AbrilRBS