Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for tools.rename() #2099

Merged
merged 3 commits into from May 24, 2021
Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented May 20, 2021

@danimtb danimtb added this to the 1.37 milestone May 20, 2021
Comment on lines 78 to 79
Utility functions to rename a file or folder *src* to *dst* with retrying. ``os.rename()`` frequently raises "Access is denied" exception on
windows. This function renames file or folder using :command:`robocopy` to avoid the exception on Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can clarify that the retry will be done in Windows if robocopy is found in the system .
Also, we may limit in Conan the number of retries, looks like it will retry 1.000.000 times with 30 seconds intervals by default? https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/robocopy

@czoido czoido merged commit 05fa7ab into conan-io:develop May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants