Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake_layout customization #2561

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Jun 1, 2022


def cmake_layout(conanfile, generator=None, src_folder="."):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't make sense anymore to show all the code

Copy link
Member

@memsharded memsharded Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it was slightly annoying for me too, because of being too large, and now split in different functions. Maybe we want a simplified example of a generic layout() that is a bit more realistic. Or maybe showing the vs_layout() or something, to illustrate what type of things can be done. (Can be done in 2.0 docs)

reference/conanfile/tools/cmake/cmake_layout.rst Outdated Show resolved Hide resolved
reference/conanfile/tools/cmake/cmake_layout.rst Outdated Show resolved Hide resolved
reference/conanfile/tools/cmake/cmake_layout.rst Outdated Show resolved Hide resolved
reference/conanfile/tools/cmake/cmake_layout.rst Outdated Show resolved Hide resolved
@czoido czoido merged commit b66b90a into conan-io:develop Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants