-
Notifications
You must be signed in to change notification settings - Fork 377
PipEnv docs added #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PipEnv docs added #4247
Conversation
This won't pass until we merge the PR |
---------------------------------- | ||
|
||
To use a tool installed with Python, we have to install it using the ``PipEnv install`` method. | ||
We also have to call the ``PipEnv generate`` method to create a ``Conan Environment`` to adds the ``Python virtualenv path`` to the system path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use backticks
mostly for things related to source code.
reference/tools/system.rst
Outdated
:maxdepth: 2 | ||
|
||
system/package_manager | ||
system/pip_manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file should not be named pip_manager but pipenv or something similar.
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
reference/tools/system/pipenv.rst
Outdated
The ``PipEnv`` helper installs Python packages with **pip** inside a dedicated virtual environment (**venv**), | ||
keeping them isolated so they don't interfere with system packages or the Conan package itself. | ||
|
||
.. currentmodule:: conan.tools.system | ||
|
||
.. autoclass:: PipEnv | ||
:members: | ||
:inherited-members: | ||
|
||
It is designed to be used in two different ways: | ||
|
||
1. Using a Python package in a recipe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this, probably the whole doc need to emphasize this is only for executable Python packages. This approach doesn't work for library-like Python code that you expect to use via import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an important
note at the beginning to clarify this would help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor review
reference/tools/system/pipenv.rst
Outdated
|
||
These two steps appear in the following recipe in the ``generate()`` method. | ||
Calling it in this method ensures that the **Python package** and the **Conan Environment** will be available in the following steps. | ||
In this case, in the build step, which is where we will use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite know what this sentence is referring to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this means is that if you haven't called it in the generate method, it won't be available in the build method, because the conan environment has to be generated before calling build.
Co-authored-by: Abril Rincón Blanco <5364255+AbrilRBS@users.noreply.github.com>
Co-authored-by: Abril Rincón Blanco <5364255+AbrilRBS@users.noreply.github.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Docs for conan-io/conan#18923