Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lundgren-2020-275 #811

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Lundgren-2020-275 #811

merged 4 commits into from
Apr 6, 2020

Conversation

Kristina-Pianykh
Copy link
Contributor

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

  1. A new wordlist (see issue Lund-2020-275 #808)
  2. A new concept set CATFISH
  3. 'catfish' glosses in other lists are now mapped to CATFISH
  4. 'mourn' in Hale is now mapped to GRIEVE

Concerning the mapping in Lundgren-2020-275:
Many glosses are vague and not narrowed down to a specific concept (e.g., BACK (part of the body or side of an object?), BE FAT (=obese or in relation to meat?), DRIP (INTR.) (could be both 808 and 2253), etc.)

Question

The gloss NECK~THROAT suggests a potentially new concept NECK OR THROAT (see also a similar gloss in Payne-1991-202). Shall I add it now in this PR or rather open an issue to discuss it in more detail?

@Kristina-Pianykh
Copy link
Contributor Author

Any volunteers to manage the PR? Christoph @chrzyki, do you mind if I pin you here?

@chrzyki
Copy link
Contributor

chrzyki commented Apr 2, 2020

Sure, happy to do it. @Schweikhard, @CarolinHu, @AnnikaTjuka, would you mind reviewing?

Copy link
Collaborator

@Schweikhard Schweikhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the many ~ would have been preferable if those were just in different lines, then it'd be easier to map. Here they basically just mark that those things colexify in the elicited languages (if they do). But I guess we don't do such edits to the data.

Regarding the unclear ones, I agree, just leave them unmapped.

concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
Lundgren-2020-275-70 70 70 CROSS 1367 CROSS
Lundgren-2020-275-71 71 71 CRY (INTR.) 1839 CRY
Lundgren-2020-275-72 72 72 CULTIVATE (TR.) 1541 CULTIVATE
Lundgren-2020-275-73 73 73 CURE 499 CURE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verb or noun?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dito, what I mentioned above. Important catch, @Schweikhard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a difficult one. In Kokama this lexeme can act both as a noun and as a verb. In Omagua, however, this lexeme is translated as a noun (source: A Linguistic Analysis of Old Omagua Ecclesiastical Texts by Michael and O'Hagan (2016) (file:///C:/Users/krist/Desktop/A_Linguistic_Analysis_of_Old_Omagua_Eccl.pdf). There is more specific concept for CURE (NOUN) in the Concepticon and there are also a number of unmapped substantive 'cure' instances in other lists. I can add a new concept set then to refer to a medicine or a treatment as a whole (i.e. a hypernym to MEDICINE)

concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that one change applies to the list of Hale-1973-17XX. This list is crucial for lexibank, so it means, if you submit this, an updated version of halenepal will be due. Can you make sure we do not forget this by making an issue for github.com/lexibank/halenepal/, which you may just title "Concepticon Conceptlist was Modified"?

As a general rule: if they mention those muddy concepts with ~, take the first. You can note that in the Note in the conceptlists.tsv, as it is difficult to deal with these cases consequently.

concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
Lundgren-2020-275-70 70 70 CROSS 1367 CROSS
Lundgren-2020-275-71 71 71 CRY (INTR.) 1839 CRY
Lundgren-2020-275-72 72 72 CULTIVATE (TR.) 1541 CULTIVATE
Lundgren-2020-275-73 73 73 CURE 499 CURE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dito, what I mentioned above. Important catch, @Schweikhard

concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
concepticondata/references/references.bib Outdated Show resolved Hide resolved
@LinguList
Copy link
Contributor

LinguList commented Apr 3, 2020 via email

Copy link
Contributor

@CarolinHu CarolinHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice list! I found almost nothing in addition to what was already mentioned.

@Kristina-Pianykh
Copy link
Contributor Author

I've updated the bibtex record as well as some mappings in Lundgren according to the discussions above. Regarding the pairwise concepts with ~, I mapped them by the first item where possible. I've also introduced new concept sets: PET, SON (OF MALE EGO) and DAUGHTER (OF MALE EGO); and updated the concept relations.

Copy link
Collaborator

@AnnikaTjuka AnnikaTjuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few remarks.

concepticondata/concepticon.tsv Show resolved Hide resolved
concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
concepticondata/conceptlists/Lundgren-2020-275.tsv Outdated Show resolved Hide resolved
@LinguList
Copy link
Contributor

LinguList commented Apr 3, 2020 via email

@LinguList
Copy link
Contributor

LinguList commented Apr 3, 2020 via email

@LinguList
Copy link
Contributor

LinguList commented Apr 3, 2020 via email

Copy link
Contributor

@LinguList LinguList left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve already, it seems you all are doing a nice job here. (just don't forget to open the issue on halenepal at lexibank, so we are in the loop that we need to update it later, in case this has not yet been done).

@SimonGreenhill
Copy link
Contributor

"ego" in this context is the referent, so "GRANDCHILD (F. EGO)" means "the term used by a female person to refer to their grandchild", i.e. what your Oma calls you, but not what Opa calls you.

@SimonGreenhill
Copy link
Contributor

BTW: kinbank is coming soon, see concepts here: https://github.com/SimonGreenhill/kinbank/blob/master/kinbank/cldf/parameters.csv

@Kristina-Pianykh
Copy link
Contributor Author

@SimonGreenhill this is absolutely mind-blowing as it only proves once again how poor English is when it comes to kinship terms (which is not such a bad thing now that I think about it!).

@Kristina-Pianykh
Copy link
Contributor Author

I updated the mappings and introduced the new concept sets according to the comments and discussions above. Let me know if there is anything else I could improve, I'd be happy to do so.

@SimonGreenhill
Copy link
Contributor

English is very impoverished in many ways :)

@chrzyki
Copy link
Contributor

chrzyki commented Apr 6, 2020

Nice, thanks for all the contributions and for the neat list & concept refinements @Kristina-Pianykh. This can be merged as far as I'm concerned and will trigger a needed rebuild of halenepal (lexibank/halenepal#15).

@Kristina-Pianykh Kristina-Pianykh merged commit e0507b8 into master Apr 6, 2020
@Kristina-Pianykh Kristina-Pianykh deleted the Lund branch April 6, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants