Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd binaries are not bundled in release tarballs #368

Closed
jamieklassen opened this issue Aug 17, 2020 · 2 comments · Fixed by #370
Closed

containerd binaries are not bundled in release tarballs #368

jamieklassen opened this issue Aug 17, 2020 · 2 comments · Fixed by #370
Assignees

Comments

@jamieklassen
Copy link
Member

Problem

unzipping https://github.com/concourse/concourse/releases/download/v6.4.1/concourse-6.4.1-linux-amd64.tgz you don't see any containerd binaries, but unzipping https://storage.googleapis.com/concourse-artifacts/dev/concourse-6.4.0%2Bdev.277.4dd4ee3.linux.amd64.tgz you do.

Proposed solution

add some get steps for the containerd binaries around here:

ci/pipelines/release-v6.yml

Lines 522 to 541 in 6c5879f

- in_parallel:
- get: concourse
passed: [rc]
trigger: true
- get: unit-image
- get: version
passed: [rc]
trigger: true
- get: final-version
resource: version
passed: [rc]
params: {bump: final}
- get: gdn
passed: [rc]
trigger: true
- get: ci
- get: resource-types-alpine-image
passed: [resource-types-images]
- get: resource-types-ubuntu-image
passed: [resource-types-images]

to match

ci/pipelines/concourse.yml

Lines 539 to 556 in 6c5879f

- in_parallel:
- get: concourse
passed: [testflight, watsjs, upgrade, downgrade]
trigger: true
- get: unit-image
- get: gdn
trigger: true
- get: containerd
trigger: true
- get: runc
trigger: true
- get: cni
trigger: true
- get: ci
- get: resource-types-alpine-image
passed: [resource-types-images]
- get: resource-types-ubuntu-image
passed: [resource-types-images]

but also -

how did this happen?

what is going on with our testing that there are so many test suites labeled containerd but we're not actually adding it to our tarball? does containerd actually work with the docker image? why? what the hell?

maybe we can always build a tarball before testing (instead of baking the same dependencies into the dev image) to have more parity between our testing flows. maybe we can have some (sigh) bosh-topgun tests for containerd.

aoldershaw added a commit that referenced this issue Aug 17, 2020
#368

We'll want to add a new task that hoists other dependencies. The problem
is we can't hoist everything from a single image since the dev-image
only bundles the alpine resource types. So, rename this hoist task to
something less generic.

Signed-off-by: Izabela Gomes <igomes@pivotal.io>
Co-authored-by: Aidan Oldershaw <aoldershaw@pivotal.io>
aoldershaw added a commit that referenced this issue Aug 17, 2020
#368

rather than trying to keep the dependencies in check between the
dockerfile and the release tarball. This way, we're guaranteed to use
the same versions that we used during testing.

Signed-off-by: Izabela Gomes <igomes@pivotal.io>
Co-authored-by: Aidan Oldershaw <aoldershaw@pivotal.io>
@jamieklassen
Copy link
Member Author

jamieklassen commented Aug 17, 2020

As part of this work, please unpause https://ci.concourse-ci.org/teams/main/pipelines/release-6.3.x/jobs/bin-smoke-containerd

@aoldershaw
Copy link
Contributor

The approach we're taking is to extract the dependencies directly from the dev image so we're guaranteed to be releasing with the same versions we tested against. Before, we had no passed constraints on gdn, so we could've tested with one version and released with a different one altogether!

aoldershaw pushed a commit that referenced this issue Aug 17, 2020
#368

...rather than trying to keep the dependencies in check between the
dockerfile and the release tarball. This way, we're guaranteed to use
the same versions that we used during testing.

The hoisting is naive to the specific binaries involved, and instead
just copies all binaries from `/usr/local/concourse/bin`.

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Co-authored-by: Izabela Gomes <igomes@pivotal.io>
aoldershaw added a commit that referenced this issue Aug 18, 2020
#368

We'll want to add a new task that hoists other dependencies. The problem
is we can't hoist everything from a single image since the dev-image
only bundles the alpine resource types. So, rename this hoist task to
something less generic.

Signed-off-by: Izabela Gomes <igomes@pivotal.io>
Co-authored-by: Aidan Oldershaw <aoldershaw@pivotal.io>
aoldershaw pushed a commit that referenced this issue Aug 18, 2020
#368

...rather than trying to keep the dependencies in check between the
dockerfile and the release tarball. This way, we're guaranteed to use
the same versions that we used during testing.

The hoisting is naive to the specific binaries involved, and instead
just copies all binaries from `/usr/local/concourse/bin`.

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Co-authored-by: Izabela Gomes <igomes@pivotal.io>
aoldershaw pushed a commit that referenced this issue Aug 18, 2020
#368

...rather than trying to keep the dependencies in check between the
dockerfile and the release tarball. This way, we're guaranteed to use
the same versions that we used during testing.

The hoisting is naive to the specific binaries involved, and instead
just copies all binaries from `/usr/local/concourse/bin`.

Signed-off-by: Aidan Oldershaw <aoldershaw@pivotal.io>
Co-authored-by: Izabela Gomes <igomes@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants