Migrate to the new chart repo #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorsilva
force-pushed
the
chart-repo-migration
branch
3 times, most recently
from
5294f42
to
497b96c
Compare
7 tasks
taylorsilva
changed the title
We moved our helm chart out of the `helm/charts` repo and over to concourse/concourse-chart To make releasing and testing easier for us we're going to follow a branching strategy similar to the concourse-bosh-deployment repo. For the main concourse pipeline all tests will be done against a `dev` branch that stays updated with master and has other commits that are for unreleased changes currently on the master branch of concourse/concourse To reclarify, concourse/concourse-chart has two branches: - `master` reflects the current OSS release of the chart - `dev` reflects `master` plus other commits related to unreleased versions of `concourse/concourse` Currently this branching stragegy has no automation: - `dev` not being promoted to master - `dev` not being rebased on master before testing - need to add lint checking for the pr against our helm chart Co-authored-by: Taylor Silva <tsilva@pivotal.io> Signed-off-by: Bin Ju <bju@pivotal.io>
taylorsilva
force-pushed
the
chart-repo-migration
branch
from
497b96c
to
30e5721
Compare
cirocosta
previously requested changes
Nov 18, 2019
pipelines/branch.yml
Outdated
| @@ -335,7 +335,9 @@ jobs: | |||
| - get: unit-image | |||
| passed: [k8s-smoke] | |||
| trigger: true | |||
| - get: charts | |||
| - get: helm-charts | |||
| passed: [k8s-smoke] | |||
There was a problem hiding this comment.
Hey,
is this new passed constraint necessary? If I got it right, this one will make setting the pipeline fail, as k8s-smoke does not get helm-charts 🤔
If it is, then we'd need to add it there (have a get), or, make it passed on something that uses it.
thx!
pipelines/concourse.yml
Outdated
| passed: [k8s-smoke] | ||
| tags: [k8s-topgun] | ||
| trigger: true | ||
| - get: helm-charts | ||
| passed: [k8s-smoke] |
There was a problem hiding this comment.
same as for branch.yml - this addition here will make setting the pipeline fail
pipelines/drills.yml
Outdated
| - get: charts | ||
| - get: concourse-chart | ||
| passed: [k8s-smoke] | ||
| - get: helm-charts | ||
| passed: [k8s-smoke] |
There was a problem hiding this comment.
this passed constraint will be problematic (same as above)
28 tasks
- k8s-topgun is the only job that needs to use other charts from the helm/charts repo. k8s-topgun doesn't need to check that helm/charts passed on other jobs, since we use concourse/concourse-chart in favor of helm/charts for those jobs now. Signed-off-by: Denise Yu <dyu@pivotal.io>
cirocosta
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/pivotal/concourse-ops/issues/117
We moved our helm chart out of the
helm/chartsrepo and over toconcourse/concourse-chart
To make releasing and testing easier for us we're going to follow a
branching strategy similar to the concourse-bosh-deployment repo.
For the main concourse pipeline all tests will be done against a
devbranch that stays updated with master and has other commits that are
for unreleased changes currently on the master branch of
concourse/concourse
To reclarify, concourse/concourse-chart has two branches:
masterreflects the current OSS release of the chartdevreflectsmasterplus other commits related to unreleasedversions of
concourse/concourseCurrently this branching stragegy has no automation:
devnot being promoted to masterdevnot being rebased on master before testingRelated PR: concourse/concourse#4735
cc @taylorsilva