build: Add riscv32 and riscv64 support #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds riscv32/riscv64 cross compilation support. Notice that this patch only enforces default psABI for RV32G and RV64G. Reference: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-cc.adoc Signed-off-by: Lv Zheng <zhenglv@smart-core.cn>
This was referenced Jun 22, 2022
|
Why is this using ilp32 and lp64 when lp64d is the standard ABI to use for Unix things (lp64 is for when you don't have an FPU) and the default ABI for FreeBSD and 64-bit Linux, and ilp32d for 32-bit Linux (strictly, anything other than bare-metal -unknown-elf triples default to double-precision hard float ABIs)? |
|
In fact, why even hard-code an ABI? You should really just be picking up the toolchain's default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds riscv32/riscv64 cross compilation support. Notice
that this patch only enforces default psABI for RV32G and RV64G.
Reference: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-cc.adoc
Signed-off-by: Lv Zheng zhenglv@smart-core.cn