Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #38 (Move symlinks back into libblas) #39

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 15, 2019

cc @minrk, @SylvainCorlay

Adds a blas-devel package as suggested by @minrk and restoring symlinks in libblas for now.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'blas-devel' output doesn't have any tests.

@isuruf isuruf changed the title Revert 29 Revert #38 (Move symlinks back into libblas) Oct 15, 2019
@isuruf isuruf merged commit bff7d22 into conda-forge:master Oct 15, 2019
@minrk
Copy link
Member

minrk commented Oct 17, 2019

Awesome, thanks! One question: there appears to be no netlib blas-devel, which means:

conda create -n blas blas-devel libblas=*=netlib

fails. This means that any package with a runtime dependency on blas-devel (e.g. fenics or petsc) will result in downstream packages either failing to install, or building with openblas.

I assume the correct fix is to either add netlib outputs for blas and blas-devel, either to this repo (probably best, to keep things in sync), or update lapack-feedstock to generate blas-devel.

@isuruf
Copy link
Member Author

isuruf commented Oct 18, 2019

@minrk, can you send a PR to lapack-feedstock?

@isuruf
Copy link
Member Author

isuruf commented Oct 25, 2019

@minrk ping.

@minrk
Copy link
Member

minrk commented Oct 28, 2019

opened: conda-forge/lapack-feedstock#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants