Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brax v0.9.0 #7

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4806680498, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Errors:

2023-04-26T10:15:12.5534924Z =========================== short test summary info ============================
2023-04-26T10:15:12.5535619Z FAILED io/mjcf_test.py::MjcfTest::test_joint_ref_check - ValueError: XML Error: global coordinates no longer supported. To convert existing models, load and save them in MuJoCo 2.3.3 or older
2023-04-26T10:15:12.5536178Z Element 'compiler', line 2
2023-04-26T10:15:12.5536862Z FAILED io/mjcf_test.py::MjcfTest::test_load_urdf - FileNotFoundError: [Errno 2] No such file or directory: '$PREFIX/lib/python3.10/site-packages/brax/envs/assets/laikago/laikago_toes_zup.urdf'
2023-04-26T10:15:12.5538171Z ========== 2 failed, 1332 passed, 161 warnings in 2772.67s (0:46:12) ===========

The first error is due to the use of mujoco 2.3.5, but it has been already fixed in brax upstream, so probably the new version will not have it, and for now we can just skip it. The other error is instead due to .urdf files not being installed, and is fixed by the patch that we can re-enable.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Errors:

2023-04-26T10:15:12.5534924Z =========================== short test summary info ============================
2023-04-26T10:15:12.5535619Z FAILED io/mjcf_test.py::MjcfTest::test_joint_ref_check - ValueError: XML Error: global coordinates no longer supported. To convert existing models, load and save them in MuJoCo 2.3.3 or older
2023-04-26T10:15:12.5536178Z Element 'compiler', line 2
2023-04-26T10:15:12.5536862Z FAILED io/mjcf_test.py::MjcfTest::test_load_urdf - FileNotFoundError: [Errno 2] No such file or directory: '$PREFIX/lib/python3.10/site-packages/brax/envs/assets/laikago/laikago_toes_zup.urdf'
2023-04-26T10:15:12.5538171Z ========== 2 failed, 1332 passed, 161 warnings in 2772.67s (0:46:12) ===========

The first error is due to the use of mujoco 2.3.5, but it has been already fixed in brax upstream, so probably the new version will not have it, and for now we can just skip it. The other error is instead due to .urdf files not being installed, and is fixed by the patch that we can re-enable.

See also google/brax#346 .

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Jun 3, 2023
3 tasks
@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Sep 8, 2023
3 tasks
@traversaro traversaro closed this Sep 22, 2023
@traversaro traversaro reopened this Sep 22, 2023
@traversaro
Copy link
Contributor

Now the failure is:

chex 0.1.83 has requirement jax>=0.4.16, but you have jax 0.4.13.

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor

The problem is (beside chex that has inconsistent constraints between pypi and conda-forge packages) is that the version of flax in conda-forge is quite old, see the error:

traversaro@IITICUBLAP257:~$ mamba create -n testjaxflax flax "jax>=0.4.16"

                  __    __    __    __
                 /  \  /  \  /  \  /  \
                /    \/    \/    \/    \
███████████████/  /██/  /██/  /██/  /████████████████████████
              /  / \   / \   / \   / \  \____
             /  /   \_/   \_/   \_/   \    o \__,
            / _/                       \_____/  `
            |/
        ███╗   ███╗ █████╗ ███╗   ███╗██████╗  █████╗
        ████╗ ████║██╔══██╗████╗ ████║██╔══██╗██╔══██╗
        ██╔████╔██║███████║██╔████╔██║██████╔╝███████║
        ██║╚██╔╝██║██╔══██║██║╚██╔╝██║██╔══██╗██╔══██║
        ██║ ╚═╝ ██║██║  ██║██║ ╚═╝ ██║██████╔╝██║  ██║
        ╚═╝     ╚═╝╚═╝  ╚═╝╚═╝     ╚═╝╚═════╝ ╚═╝  ╚═╝

        mamba (1.4.2) supported by @QuantStack

        GitHub:  https://github.com/mamba-org/mamba
        Twitter: https://twitter.com/QuantStack

█████████████████████████████████████████████████████████████

WARNING: A conda environment already exists at '/home/traversaro/miniforge3/envs/testjaxflax'
Remove existing environment (y/[n])? y


Looking for: ['flax', "jax[version='>=0.4.16']"]

warning  libmamba Cache file "/home/traversaro/miniforge3/pkgs/cache/497deca9.json" was modified by another program
warning  libmamba Cache file "/home/traversaro/miniforge3/pkgs/cache/09cdf8bf.json" was modified by another program
conda-forge/noarch                                  14.2MB @   1.7MB/s  9.1s
conda-forge/linux-64                                34.4MB @   2.4MB/s 15.7s
Could not solve for environment specs
The following packages are incompatible
├─ flax   is installable with the potential options
│  ├─ flax [0.3.2|0.3.3|...|0.5.0] would require
│  │  └─ jax >=0.2.6,<0.4.14 , which can be installed;
│  └─ flax [0.5.1|0.5.2|0.6.1] would require
│     └─ jax >=0.3.2,<0.4.14 , which can be installed;
└─ jax >=0.4.16  is uninstallable because it conflicts with any installable versions previously reported.

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Oct 20, 2023
3 tasks
@traversaro
Copy link
Contributor

is that the version of flax in conda-forge is quite old, see the error:

See conda-forge/flax-feedstock#29 (comment) . In a nutshell, this is currently blocked by the missing tensorstore recipe, that however it should be added in conda-forge/staged-recipes#17848 .

@traversaro
Copy link
Contributor

@conda-forge-admin please re-render.

@traversaro
Copy link
Contributor

Test fails with:

FAILED actuator_test.py::ActuatorTest::test_motor0 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED actuator_test.py::ActuatorTest::test_motor1 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED actuator_test.py::ActuatorTest::test_motor2 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED actuator_test.py::ActuatorTest::test_position - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED io/mjcf_test.py::MjcfTest::test_load_humanoid - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED io/mjcf_test.py::MjcfTest::test_load_mesh_and_box - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED io/mjcf_test.py::MjcfTest::test_load_pendulum - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED io/mjcf_test.py::MjcfTest::test_load_urdf - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED io/mjcf_test.py::MjcfTest::test_rgba - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED io/mjcf_test.py::MjcfTest::test_world_body_transform - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/joints_test.py::JointsTest::test_sphericalize_humanoid - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/perf_test.py::PerfTest::test_pipeline_ant - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/pipeline_test.py::PipelineTest::test_3d_prismaversal_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/pipeline_test.py::PipelineTest::test_3d_sliding_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/pipeline_test.py::PipelineTest::test_pendulum - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/pipeline_test.py::PipelineTest::test_sliding_capsule - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED positional/pipeline_test.py::PipelineTest::test_spherical_pendulum - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/joints_test.py::JointTest::test_pendulum_period0 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/joints_test.py::JointTest::test_pendulum_period1 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/joints_test.py::JointTest::test_pendulum_period2 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/perf_test.py::PerfTest::test_pipeline_ant - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_2d_prismaversal_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_2d_sliding_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_3d_prismaversal_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_3d_sliding_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_pendulum - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_prismatic_joint - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_sliding_capsule - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_spherical_pendulum - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED spring/pipeline_test.py::PipelineTest::test_universal_pendulum - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
FAILED training/agents/ppo/train_test.py::PPOTest::testTrainV2 - AttributeError: 'mujoco._structs.MjOption' object has no attribute 'collision'
== 100 failed, 1233 passed, 1 deselected, 162 warnings in 1436.69s (0:23:56) ===

@traversaro
Copy link
Contributor

Ok, probably at this point we can just look in packaging brax v0.9.3, and try to package v0.9.0 only if necessary.

@traversaro traversaro closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants