Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin run-env cython for consistency with requirements.txt #63

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

matbryan52
Copy link
Contributor

@matbryan52 matbryan52 commented Apr 18, 2024

We noted here conda-forge/libertem-blobfinder-feedstock#1 that hdbscan causes pip check to fail as the conda recipe in this repo requires any cython but the requirements.txt file (https://github.com/scikit-learn-contrib/hdbscan/blob/0.8.33/requirements.txt, read into setup.py and used by pip) limits cython to >=0.27,<3. The pin would be temporary until this PR is merged scikit-learn-contrib/hdbscan#624 to remove cython at runtime and the conda recipe also updated.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@matbryan52
Copy link
Contributor Author

@conda-forge-admin please rerender

@lmcinnes lmcinnes merged commit 1a1572e into conda-forge:main Apr 18, 2024
32 checks passed
@matbryan52 matbryan52 deleted the cython-pin branch April 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants