Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable unix build #3

Merged
merged 9 commits into from
Nov 9, 2020
Merged

Enable unix build #3

merged 9 commits into from
Nov 9, 2020

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Nov 8, 2020 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer Tobias-Fischer mentioned this pull request Nov 8, 2020
Merged
5 tasks
@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2020

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2020

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@Tobias-Fischer
Copy link
Contributor Author

@seanyen
This is ready to be merged. Please have a look at the diff as I changed the recipe output stuff.

/cc @wolfv @traversaro

traversaro
traversaro reviewed Nov 8, 2020
View reviewed changes
recipe/build.sh
-DCMAKE_PREFIX_PATH=$PREFIX -DCMAKE_INSTALL_PREFIX=$PREFIX \
-DCMAKE_INSTALL_LIBDIR=lib \
-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=True \
-DCMAKE_CXX_STANDARD=17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is any specific reason why this was necessary? In theory if the project has a minimum required C++ version, this should be accounted as part of the CMake script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this blindly from https://github.com/conda-forge/libignition-common-feedstock/blob/master/recipe/build.sh

Maybe @wolfv can comment on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or @seanyen actually as he has written this build script)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, no problem then. However I think that everything should probably work even by removing that option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically all of conda-forge uses c++17 by default. I would also guess that this isn't strictly necessary.

traversaro
traversaro reviewed Nov 8, 2020
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@wolfv
Copy link
Member

wolfv commented Nov 9, 2020

Looks good to me.

@Tobias-Fischer
Copy link
Contributor Author

Cool. Should we merge this one then? :)

@wolfv wolfv merged commit 3d8b1c5 into conda-forge:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfv wolfv wolfv left review comments

@traversaro traversaro traversaro approved these changes

@seanyen seanyen Awaiting requested review from seanyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tobias-Fischer @conda-forge-linter @wolfv @traversaro