Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for msmpi tests #43

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

leofang
Copy link
Member

@leofang leofang commented Apr 29, 2021

I think with conda-forge/msmpi-feedstock#11 testing msmpi in downstream packages should just work out of box. Although msmpi.dll is fixed to resolve the 32/64 bit issue, I don't think we need a rebuild, so this is just for testing.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Member Author

leofang commented Apr 29, 2021

Windows builds failed (which is good) because the upstream update has not propagated to the CDN yet. Let's restart in ~1 hr.

@leofang
Copy link
Member Author

leofang commented Apr 29, 2021

@conda-forge-admin, please restart ci

@leofang
Copy link
Member Author

leofang commented Apr 29, 2021

@dalcinl It worked!!!

@leofang leofang changed the title [DO NOT MERGE] Remove workaround for msmpi tests Remove workaround for msmpi tests Apr 29, 2021
@leofang leofang marked this pull request as ready for review April 29, 2021 07:15
@leofang
Copy link
Member Author

leofang commented Apr 29, 2021

Due to mpi4py/mpi4py#19 (comment) I think we need this...

@leofang leofang merged commit a2eb007 into conda-forge:master Apr 29, 2021
@leofang leofang deleted the rebuild_msmpi_round2 branch April 29, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants