Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use installer outputs & Fix (de)activate scripts #11

Merged
merged 8 commits into from
Apr 29, 2021
Merged

Use installer outputs & Fix (de)activate scripts #11

merged 8 commits into from
Apr 29, 2021

Conversation

leofang
Copy link
Member

@leofang leofang commented Apr 28, 2021 •
edited
Loading

Close #2.

This PR does 3 things:

  1. Use Windows installer and install (not extract!) to $PREFIX\Library
  2. Fix (de)activate scripts to not print debug messages in user environments
  3. Erase the pre-installed MPI from Conda-Forge's VM image so that downstream packages can test MPI against msmpi

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Member Author

leofang commented Apr 28, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@leofang
Copy link
Member Author

leofang commented Apr 28, 2021

Hmmm, ok, so if we remove the old MPI runtime and then install, -installroot will work...Interesting.

@leofang
Copy link
Member Author

leofang commented Apr 28, 2021 •
edited
Loading

Hmmm, ok, so if we remove the old MPI runtime and then install, -installroot will work...Interesting.

I should have noticed this in ddccb52 from #7!!!

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=308809&view=results

@leofang leofang marked this pull request as draft April 28, 2021 21:04
@leofang leofang marked this pull request as ready for review April 29, 2021 01:46
@leofang
Copy link
Member Author

leofang commented Apr 29, 2021

PR description updated. Note that using the installer properly should fix the 32 vs 64 bit issue (default is 32 bit if extracting from the exe directly)...

@leofang leofang merged commit 7fc2c26 into conda-forge:master Apr 29, 2021
@leofang leofang deleted the install_10.1.2 branch April 29, 2021 01:52
This was referenced Apr 29, 2021
Merged
Merged
Closed
Merged
@leofang
Copy link
Member Author

leofang commented Apr 29, 2021

Verified working in downstream packages:

@jakirkham jakirkham mentioned this pull request Apr 30, 2021
Closed
isuruf added a commit to isuruf/msmpi-feedstock that referenced this pull request Jun 10, 2021
@isuruf
Revert "Merge pull request conda-forge#11 from leofang/install_10.1.2"
c465cc9 
This reverts commit 7fc2c26, reversing
changes made to 4b681b2.
RyanMcCarthy-NOAA pushed a commit that referenced this pull request Jun 16, 2021
@isuruf
Go back to build from source (#14)
58b78e6 
* Revert "Merge pull request #11 from leofang/install_10.1.2"

This reverts commit 7fc2c26, reversing
changes made to 4b681b2.

* Revert "Merge pull request #9 from leofang/fix_line_ending"

This reverts commit 4b681b2, reversing
changes made to 4a424b8.

* Revert "Merge pull request #8 from leofang/10.1.2"

This reverts commit 4a424b8, reversing
changes made to b7ad985.

* Revert "Switch to official installer (#6)"

This reverts commit b7ad985.

* updpate build number and fix activate scripts

* Add me as a maintainer

* Add back tests from reverted PR

Original author: leofang

* wrap description

original author: leofang

* Add a warning about system msmpi

* Tests -> tests

* source_files -> files

* comment out test

* Fix MSMPI_VER

Original Author: leofang

* MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.1, and conda-forge-pinning 2021.06.11.18.15.44

* improve testing

Co-authored-by: conda-forge-linter <github-actions@email.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanMcCarthy-NOAA RyanMcCarthy-NOAA Awaiting requested review from RyanMcCarthy-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Note for package maintainers: Don't test running msmpi in your recipe
2 participants
@leofang @conda-forge-linter