Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to official installer #6

Merged
merged 54 commits into from
Apr 25, 2021
Merged

Switch to official installer #6

merged 54 commits into from
Apr 25, 2021

Conversation

leofang
Copy link
Member

@leofang leofang commented Apr 23, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Member Author

leofang commented Apr 23, 2021

@conda-forge-admin, please rerender

@leofang leofang changed the title [WIP] Switch to official installer [WIP] MS-MPI v10.1.2; Switch to official installer Apr 23, 2021
@leofang leofang changed the title [WIP] MS-MPI v10.1.2; Switch to official installer [WIP] Switch to official installer Apr 25, 2021
@leofang leofang changed the title [WIP] Switch to official installer Switch to official installer Apr 25, 2021
@leofang leofang marked this pull request as ready for review April 25, 2021 15:22
@leofang
Copy link
Member Author

leofang commented Apr 25, 2021

@mccarthyryanc @RyanMcCarthy-NOAA @dalcinl This is ready. Once this 10.1.1 fix is in, I will proceed to package 10.1.2. Then, we can rebuild mpi4py.

@dalcinl
Copy link

dalcinl commented Apr 25, 2021

Then, we can rebuild mpi4py.

You should add the following trivial line to the test section of mpi4py's recipe:

python -c 'from mpi4py import MPI; print(MPI.get_vendor())'

dalcinl
dalcinl reviewed Apr 25, 2021
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@dalcinl
Copy link

dalcinl commented Apr 25, 2021

I suggest to merge this MR with a squash. There is no point on keeping this messy history.

@leofang
Copy link
Member Author

leofang commented Apr 25, 2021

Note: Another reason to not test mpi4py in this repo is that it leaks the Python dependency, causing Python to become a run dependency. I think this is a bug in either conda-build or conda-smithy.

RyanMcCarthy-NOAA
RyanMcCarthy-NOAA approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@RyanMcCarthy-NOAA RyanMcCarthy-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leofang and @dalcinl strong work!

@RyanMcCarthy-NOAA RyanMcCarthy-NOAA merged commit b7ad985 into conda-forge:master Apr 25, 2021
@leofang leofang deleted the use_installer branch April 25, 2021 20:02
@leofang
Copy link
Member Author

leofang commented Apr 25, 2021

Thanks guys!

This was referenced Apr 26, 2021
Closed
Merged
Closed
Merged
@isuruf isuruf mentioned this pull request Apr 30, 2021
Closed
isuruf added a commit to isuruf/msmpi-feedstock that referenced this pull request Jun 10, 2021
@isuruf
Revert "Switch to official installer (conda-forge#6)"
727adec 
This reverts commit b7ad985.
RyanMcCarthy-NOAA pushed a commit that referenced this pull request Jun 16, 2021
@isuruf
Go back to build from source (#14)
58b78e6 
* Revert "Merge pull request #11 from leofang/install_10.1.2"

This reverts commit 7fc2c26, reversing
changes made to 4b681b2.

* Revert "Merge pull request #9 from leofang/fix_line_ending"

This reverts commit 4b681b2, reversing
changes made to 4a424b8.

* Revert "Merge pull request #8 from leofang/10.1.2"

This reverts commit 4a424b8, reversing
changes made to b7ad985.

* Revert "Switch to official installer (#6)"

This reverts commit b7ad985.

* updpate build number and fix activate scripts

* Add me as a maintainer

* Add back tests from reverted PR

Original author: leofang

* wrap description

original author: leofang

* Add a warning about system msmpi

* Tests -> tests

* source_files -> files

* comment out test

* Fix MSMPI_VER

Original Author: leofang

* MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.1, and conda-forge-pinning 2021.06.11.18.15.44

* improve testing

Co-authored-by: conda-forge-linter <github-actions@email.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalcinl dalcinl dalcinl left review comments

@RyanMcCarthy-NOAA RyanMcCarthy-NOAA RyanMcCarthy-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leofang @conda-forge-linter @dalcinl @RyanMcCarthy-NOAA