Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump build number, update URL and add patch to build with METIS 5.1.1 #88

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Bump build number, update URL and add patch to build with METIS 5.1.1 #88

merged 13 commits into from
Dec 1, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 30, 2023 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro changed the title [DRAFT] Bump build number to build with METIS 5.1.1 [DRAFT] Bump build number and update URL to build with METIS 5.1.1 Aug 30, 2023
conda-forge-webservices[bot] and others added 2 commits August 30, 2023 09:43
@traversaro
Copy link
Contributor Author

Some macos builds fail with:

Error: Type mismatch in argument ‘s’ at (1); passed INTEGER(4) to LOGICAL(4)
mpi.f:575:72:

  575 |          CALL MUMPS_COPY_LOGICAL( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘r’ at (1); passed INTEGER(4) to LOGICAL(4)
mpi.f:577:72:

  577 |          CALL MUMPS_COPY_REAL( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘s’ at (1); passed INTEGER(4) to REAL(4)
mpi.f:577:72:

  577 |          CALL MUMPS_COPY_REAL( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘r’ at (1); passed INTEGER(4) to REAL(4)
mpi.f:580:72:

  580 |          CALL MUMPS_COPY_DOUBLE_PRECISION( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘s’ at (1); passed INTEGER(4) to REAL(8)
mpi.f:580:72:

  580 |          CALL MUMPS_COPY_DOUBLE_PRECISION( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘r’ at (1); passed INTEGER(4) to REAL(8)
mpi.f:582:72:

Based on coin-or/coinbrew#47 (comment) probably we should pass -fallow-argument-mismatch somewhere.

@traversaro
Copy link
Contributor Author

Based on coin-or/coinbrew#47 (comment) probably we should pass -fallow-argument-mismatch somewhere.

See also conda-forge/scalapack-feedstock#30 (comment) .

@traversaro
Copy link
Contributor Author

Some macos builds fail with:

Error: Type mismatch in argument ‘s’ at (1); passed INTEGER(4) to LOGICAL(4)
mpi.f:575:72:

  575 |          CALL MUMPS_COPY_LOGICAL( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘r’ at (1); passed INTEGER(4) to LOGICAL(4)
mpi.f:577:72:

  577 |          CALL MUMPS_COPY_REAL( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘s’ at (1); passed INTEGER(4) to REAL(4)
mpi.f:577:72:

  577 |          CALL MUMPS_COPY_REAL( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘r’ at (1); passed INTEGER(4) to REAL(4)
mpi.f:580:72:

  580 |          CALL MUMPS_COPY_DOUBLE_PRECISION( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘s’ at (1); passed INTEGER(4) to REAL(8)
mpi.f:580:72:

  580 |          CALL MUMPS_COPY_DOUBLE_PRECISION( SENDBUF, RECVBUF, CNT )
      |                                                                        1
Error: Type mismatch in argument ‘r’ at (1); passed INTEGER(4) to REAL(8)
mpi.f:582:72:

Based on coin-or/coinbrew#47 (comment) probably we should pass -fallow-argument-mismatch somewhere.

The osx-64 fortran compiler is gfortran 12, while in the latest build was gfortran 9, that is the reason why we now need the workaround also for osx-64 .

minrk
minrk approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title says draft, but it's all looking okay to me, now. LMK when you think this is ready.

@traversaro
Copy link
Contributor Author

Title says draft, but it's all looking okay to me, now. LMK when you think this is ready.

It is not, basically mumps hardcode some indeces that changed between metis 5.1.0 and 5.1.1 and so at runtime in some cases it would crash, see KarypisLab/METIS#71 (comment) . I wanted to see if there was something in mumps recipe itself that could capture this, but unfortunatly that is not the case.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro marked this pull request as draft August 30, 2023 13:53
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [63]

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro changed the title [DRAFT] Bump build number and update URL to build with METIS 5.1.1 Bump build number, update URL and add patch to build with METIS 5.1.1 Aug 30, 2023
@traversaro
Copy link
Contributor Author

I tested locally and the new package with the patch https://github.com/conda-forge/mumps-feedstock/pull/88/files#diff-e5ce6becdc05048d65fd83496744f16748ee17d9a583344a6797a51484827171 works fine with metis 5.1.1, in particular python -c "import kwant; kwant.test()" runs fine, while it failed with "Segmentation Fault" without this patch (see conda-forge/metis-feedstock#35).

fyi @akhmerov

@traversaro traversaro marked this pull request as ready for review August 30, 2023 15:55
@traversaro traversaro closed this Aug 30, 2023
@traversaro traversaro reopened this Aug 30, 2023
@traversaro
Copy link
Contributor Author

If anyone has any idea of a test we could add here to fail as python -c "import kwant; kwant.test()" fails, it would be great.

@traversaro traversaro mentioned this pull request Aug 30, 2023
Merged
2 tasks
@traversaro
Copy link
Contributor Author

At the moment the build is failing as on linux-ppc64le there is not metis 5.1.1 build, see conda-forge/conda-forge-pinning-feedstock#4857 (comment) for the full context.

@traversaro traversaro closed this Nov 1, 2023
@traversaro traversaro reopened this Nov 1, 2023
@traversaro
Copy link
Contributor Author

At the moment the build is failing as on linux-ppc64le there is not metis 5.1.1 build, see conda-forge/conda-forge-pinning-feedstock#4857 (comment) for the full context.

This was fixed by conda-forge/metis-feedstock#40 , the PR should now be ready.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

The PR is ready for review @conda-forge/mumps

@traversaro traversaro mentioned this pull request Nov 9, 2023
Closed
@traversaro
Copy link
Contributor Author

The PR is ready for review @conda-forge/mumps

It would be great to merge this, so we can unblock #89, thanks!

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro mentioned this pull request Nov 30, 2023
Merged
@minrk minrk merged commit 3b1bd87 into conda-forge:main Dec 1, 2023
13 checks passed
@traversaro traversaro mentioned this pull request Dec 1, 2023
Closed
This was referenced Jan 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk approved these changes

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@basnijholt basnijholt Awaiting requested review from basnijholt basnijholt is a code owner

@dalcinl dalcinl Awaiting requested review from dalcinl dalcinl is a code owner

@davidbrochart davidbrochart Awaiting requested review from davidbrochart davidbrochart is a code owner

@jbweston jbweston Awaiting requested review from jbweston jbweston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @minrk