Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Depend on libosqp #36

Closed
wants to merge 6 commits into from
Closed

Conversation

traversaro
Copy link

Work in progress to fix #35 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Thanks for tackling this! Your patch isn't quite functional yet, it seems...

@h-vetinari
Copy link
Member

@bstellato @gbanjac
After discussion in #25, the proposal is to depend on a separately built libosqp, not least since the releases upstream are also not necessarily in sync.

What do you think about the approach, and would you be willing to accept a patch upstream for using an "external" osqp like @traversaro is preparing in this PR?

@traversaro
Copy link
Author

@bstellato @gbanjac
After discussion in #25, the proposal is to depend on a separately built libosqp, not least since the releases upstream are also not necessarily in sync.

What do you think about the approach, and would you be willing to accept a patch upstream for using an "external" osqp like @traversaro is preparing in this PR?

To clarify, the osqp and qdldl sources would still be necessary to support codegen, it just the Python extension on its own that will be linking an external shared osqp library provided by the libosqp package.

Thanks for tackling this! Your patch isn't quite functional yet, it seems...

Yes, I am still working on it, I don't have a lot of experience with setup.py-based builds, so I need to learn on the fly. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants