Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for proj910 #122

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update proj910.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3002051153, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@snowman2
Copy link
Member

snowman2 commented Sep 6, 2022

I recommend waiting for the pyproj 3.4 release. I plan on making a release candidate soon.

@ocefpaf ocefpaf marked this pull request as draft September 6, 2022 22:06
@snowman2
Copy link
Member

snowman2 commented Sep 9, 2022

The minimum supported PROJ version is 8.2 (pyproj4/pyproj#1011) for this release. What is the recommended approach to update the pin?

@xylar
Copy link
Contributor

xylar commented Sep 9, 2022

The minimum supported PROJ version is 8.2 (pyproj4/pyproj#1011) for this release. What is the recommended approach to update the pin?

I don't think there's anything to do. We build with one specific version of proj and that same version is required at runtime:
https://github.com/conda-forge/proj.4-feedstock/blob/main/recipe/meta.yaml#L18
So this build will only support PROJ 9.1.0. We would have to make a separate build of pyproj 3.4.0 to support any other proj version.

@snowman2 snowman2 marked this pull request as ready for review September 10, 2022 03:18
@xylar
Copy link
Contributor

xylar commented Sep 10, 2022

@snowman2, sorry, what I told you is totally incorrect. We currently build for older proj, too:
https://github.com/conda-forge/pyproj-feedstock/blob/main/recipe/conda_build_config.yaml#L2-L3

@xylar
Copy link
Contributor

xylar commented Sep 10, 2022

Based on this comment #96 (comment), we should just remove old proj.

@xylar xylar changed the title Rebuild for proj910 Update to v3.4.0 and rebuild for proj910 Sep 10, 2022
@xylar
Copy link
Contributor

xylar commented Sep 10, 2022

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor

xylar commented Sep 10, 2022

@snowman2, I actually think it might be better to build v3.4.0 first with proj 9.0.1 and then migrate to proj 9.1.0. Does that sound reasonable?

@xylar xylar marked this pull request as draft September 10, 2022 03:51
@snowman2
Copy link
Member

@snowman2, I actually think it might be better to build v3.4.0 first with proj 9.0.1 and then migrate to proj 9.1.0. Does that sound reasonable?

Sounds good to me 👍

@xylar
Copy link
Contributor

xylar commented Sep 10, 2022

@conda-forge-admin, please rerender

@xylar xylar changed the title Update to v3.4.0 and rebuild for proj910 Rebuild for proj910 Sep 10, 2022
@xylar xylar marked this pull request as ready for review September 10, 2022 04:58
@xylar xylar added the automerge Merge the PR when CI passes label Sep 10, 2022
@xylar
Copy link
Contributor

xylar commented Sep 10, 2022

Okay, this one is rebased and looks clean to me.

@github-actions github-actions bot merged commit 40f6896 into conda-forge:main Sep 10, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-proj910-0-1_h30bb55 branch September 10, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants