Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 3.10.0 #481

Merged
merged 78 commits into from
Oct 5, 2021
Merged

Update to 3.10.0 #481

merged 78 commits into from
Oct 5, 2021

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Aug 16, 2021 •
edited by chrisburr
Loading

  • remove upstreamed patch Fix-off-by-one-error-in-_winapi_WaitForMultipleObjec.patch
  • remove unnecessary patch Darwin-Add-arch-x86_64-to-UnicCCompiler-ld_args.patch
  • remove Add-support-for-_CONDA_PYTHON_SYSCONFIGDATA_NAME-if-.patch
  • unvendor libffi
  • unvendor bzip2
  • unvendor xz
  • unvendor zlib
  • unvendor tcl/tk
  • remove egg-debugging-with-Windows-debug-builds.patch
  • strip 0018-Add-CondaEcosystemModifyDllSearchPath.patch
  • Fix d1trimfile so that it's added only to cl.exe
  • workaround Fix pinning expressions for prerelease builds conda/conda-build#4272 if possible.
  • use libffi for osx-arm64 too
  • check that DT_RUNPATH is not set with new GNULD fix
  • use bzip2 shared library on unix
  • use libuuid on unix

Closes #508
Closes #509

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy xhochy mentioned this pull request Aug 18, 2021
Closed
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

h-vetinari
h-vetinari reviewed Aug 20, 2021
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Looks like the final release just dropped

#509

@isuruf isuruf changed the title Update to 3.10.0rc1 Update to 3.10.0 Oct 4, 2021
@h-vetinari
Copy link
Member

This is amazing work 🥇

chrisburr
chrisburr approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@chrisburr chrisburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 🍰

mariusvniekerk
mariusvniekerk reviewed Oct 5, 2021
View reviewed changes
recipe/build_base.bat
@@ -82,12 +82,6 @@ if errorlevel 1 exit 1
mkdir %PREFIX%\DLLs
xcopy /s /y %SRC_DIR%\PCBuild\%BUILD_PATH%\*.pyd %PREFIX%\DLLs\
if errorlevel 1 exit 1
copy /Y %SRC_DIR%\PCbuild\%BUILD_PATH%\tcl86t.dll %PREFIX%\DLLs\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much nicer

@isuruf isuruf force-pushed the 3.10 branch 2 times, most recently from 59735f8 to b73bd98 Compare October 5, 2021 19:53
@isuruf isuruf added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Oct 5, 2021
@github-actions github-actions bot merged commit 1f851cb into conda-forge:master Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@isuruf isuruf deleted the 3.10 branch October 5, 2021 22:52
@isuruf isuruf mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@mbargull mbargull mbargull left review comments

@chrisburr chrisburr chrisburr approved these changes

@mariusvniekerk mariusvniekerk mariusvniekerk left review comments

@xhochy xhochy xhochy left review comments

@katietz katietz katietz approved these changes

@ocefpaf ocefpaf ocefpaf approved these changes

@jakirkham jakirkham Awaiting requested review from jakirkham

@mingwandroid mingwandroid Awaiting requested review from mingwandroid

@msarahan msarahan Awaiting requested review from msarahan

@pelson pelson Awaiting requested review from pelson

@scopatz scopatz Awaiting requested review from scopatz

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.