Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for jaxsim #24630

Merged
merged 8 commits into from
Feb 4, 2024
Merged

Add recipe for jaxsim #24630

merged 8 commits into from
Feb 4, 2024

Conversation

flferretti
Copy link
Contributor

@flferretti flferretti commented Nov 30, 2023

This is a grayskull-generated recipe for jaxsim pure-Python package.

PyPI: https://pypi.org/project/jaxsim/
Repo: https://github.com/ami-iit/jaxsim

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jaxsim) and found it was in an excellent condition.

@flferretti
Copy link
Contributor Author

@diegoferigo can you please confirm you want to be added as a maintainer?

@diegoferigo
Copy link
Contributor

@diegoferigo can you please confirm you want to be added as a maintainer?

Yes, thanks for opening the PR!

@flferretti
Copy link
Contributor Author

@traversaro can you please confirm you want to be added as a maintainer?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/jaxsim) and found some lint.

Here's what I've got...

For recipes/jaxsim:

  • The following maintainers have not yet confirmed that they are willing to be listed here: traversaro. Please ask them to comment on this PR if they are.

@traversaro
Copy link
Contributor

@traversaro can you please confirm you want to be added as a maintainer?

Yes!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jaxsim) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jaxsim) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/jaxsim:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [14].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jaxsim) and found it was in an excellent condition.

@flferretti flferretti marked this pull request as ready for review January 25, 2024 13:50
@flferretti
Copy link
Contributor Author

flferretti commented Jan 25, 2024

@conda-forge/help-python @conda-forge/staged-recipes PR ready for review, thanks!
The Windows failure is expected as JAX is not available on Windows, moreover this is a noarch recipe, so it should not be a problem. The OSX failure seems related to external reasons

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

recipes/jaxsim/meta.yaml Outdated Show resolved Hide resolved
@xhochy xhochy merged commit b1e4726 into conda-forge:main Feb 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants