Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: pyospackage recipe to conda-forge (pyOpenSci) #25173

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jan 30, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@lwasser lwasser changed the title Add: pyospackage recipe to conda-forge Add: pyospackage recipe to conda-forge (pyOpenSci) Jan 30, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyospackage) and found some lint.

Here's what I've got...

For recipes/pyospackage:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyospackage) and found it was in an excellent condition.

recipes/pyospackage/meta.yaml Outdated Show resolved Hide resolved
@lwasser
Copy link
Member Author

lwasser commented Feb 1, 2024

hey there @ocefpaf 👋 this is the pyOpenSci package I was telling you about. For some reason it's failing windows now. i'm open to making changes but i'm not sure where to start. it's a fairly simple package with no dependencies. many thanks!

@lwasser lwasser marked this pull request as ready for review February 1, 2024 20:16
- pip

about:
home: https://pypi.org/project/pyospackage/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to manually add this as grayskull seems to not add this element no matter what is in the pyproject.toml file.

@ocefpaf
Copy link
Member

ocefpaf commented Feb 2, 2024

Hey @lwasser, I updated the branch b/c the failure was in a dangling package, not your recipe. Things should pass now. Also, I see you already opened an issue for grayskull. I'll check it upstream ASAP.

Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser the recipe is perfect. My guess is that you don't want to merge this, right? But, if you do, it passes the review process and should pass the CIs. Let me know if you need anything else.

@lwasser
Copy link
Member Author

lwasser commented Feb 2, 2024

@ocefpaf if it is ok to merge this, i'd love to do that. i'll then add a section on how to maintain a conda-forge feedstock and i can do a demo that shows how the pypi - conda-forge connection works on the user end.

@lwasser
Copy link
Member Author

lwasser commented Feb 2, 2024

Also thank you for reviewing and fixing the pr! grayskull just don't add a home: key:value pair in my yaml file no matter what is in my pyproject.toml file. so i added it manually as the linter here required it.

@ocefpaf ocefpaf merged commit e6c3f42 into conda-forge:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants