-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: pyospackage recipe to conda-forge (pyOpenSci) #25173
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pyospackage:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
hey there @ocefpaf 👋 this is the pyOpenSci package I was telling you about. For some reason it's failing windows now. i'm open to making changes but i'm not sure where to start. it's a fairly simple package with no dependencies. many thanks! |
- pip | ||
|
||
about: | ||
home: https://pypi.org/project/pyospackage/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had to manually add this as grayskull seems to not add this element no matter what is in the pyproject.toml file.
Hey @lwasser, I updated the branch b/c the failure was in a dangling package, not your recipe. Things should pass now. Also, I see you already opened an issue for grayskull. I'll check it upstream ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lwasser the recipe is perfect. My guess is that you don't want to merge this, right? But, if you do, it passes the review process and should pass the CIs. Let me know if you need anything else.
@ocefpaf if it is ok to merge this, i'd love to do that. i'll then add a section on how to maintain a conda-forge feedstock and i can do a demo that shows how the pypi - conda-forge connection works on the user end. |
Also thank you for reviewing and fixing the pr! grayskull just don't add a home: key:value pair in my yaml file no matter what is in my pyproject.toml file. so i added it manually as the linter here required it. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).