Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for blasfeo #27207

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add recipe for blasfeo #27207

merged 2 commits into from
Aug 12, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 8, 2024

blasfeo provides a set of basic linear algebra routines, performance-optimized for matrices that fit in cache (i.e. generally up to a couple hundred size in each dimension), as typically encountered in embedded optimization applications.

The package name (libblasfeo) contains the lib prefix as requested in #19764 (review) for C/C++ libraries. The feedstock is named blasfeo to match the repo name and support different package outputs in the future, if that turns out to be necessary.

I am adding blasfeo as it is a transitive dependency for a new version of the casadi library, see conda-forge/casadi-feedstock#112 .

The latest tagged version of blasfeo is relatively old and does not compile on macOS and Windows. I asked upstream if they are interested in tagging a new release (see giaf/blasfeo#181), but in the meanwhile I think we can start packaging (just for Linux) the latest tagged version.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/blasfeo/meta.yaml) and found it was in an excellent condition.

@traversaro traversaro closed this Aug 8, 2024
@traversaro traversaro reopened this Aug 8, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/blasfeo/meta.yaml) and found some lint.

Here's what I've got...

For recipes/blasfeo/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/blasfeo/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/blasfeo/meta.yaml) and found some lint.

Here's what I've got...

For recipes/blasfeo/meta.yaml:

  • Please do not delete the example recipe found in recipes/example/recipe.yaml.

@traversaro traversaro closed this Aug 10, 2024
@traversaro traversaro reopened this Aug 10, 2024
@traversaro
Copy link
Contributor Author

traversaro commented Aug 10, 2024

@conda-forge/staged-recipes @conda-forge/help-c-cpp the PR is ready for review.

The linter complains "Please do not delete the example recipe found in recipes/example/recipe.yaml.", but as the file has not been touched by this PR and the same error occurs on unrelated PRs (see #27234 or #27235), I guess the problem may be in the linter?

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ocefpaf
Copy link
Member

ocefpaf commented Aug 12, 2024

Not sure what is going on with the linter there. The example recipe is in there :-/

@ocefpaf ocefpaf merged commit f507466 into conda-forge:main Aug 12, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants