Added double-conversion #5770
Added double-conversion #5770
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
could make check substitute tests (using empty run_test.sh)? |
recipes/double-conversion/meta.yaml
Outdated
| version: {{ version }} | ||
|
|
||
| source: | ||
| git_url: https://github.com/google/{{ name }}.git |
There was a problem hiding this comment.
Is there a tarball we can use to avoid cloning the repo?
| @@ -0,0 +1,2 @@ | |||
| #!/bin/sh | |||
|
|
|||
recipes/double-conversion/meta.yaml
Outdated
|
|
||
| requirements: | ||
| build: | ||
| - gcc |
There was a problem hiding this comment.
You probably don't need gcc here.
|
@pearu thank you a lot for fixing the bug (missing include path)! |
|
@pearu I added you as a maintainer 👍 |
|
ok |
| make | ||
|
|
||
| test/cctest/cctest --list | tr -d '<' | xargs test/cctest/cctest | ||
|
|
There was a problem hiding this comment.
I'm guessing that there is no 'make check'.
| requirements: | ||
| build: | ||
| - cmake | ||
| - toolchain |
There was a problem hiding this comment.
Is this still needed when using the new compilers @msarahan?
|
Minor comments but nothing blocking the merge. |
No description provided.