-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for jpegturbo migration #288
Rebuild for jpegturbo migration #288
Conversation
…nda-forge-pinning 2023.03.12.15.24.04
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I wonder if the build errors in the |
(in other words, do we need a run req on llvmdev in the mesalib builds? |
Maybe...... |
Or a constraint |
I thought that should be added automatically according to conda-forge/mesalib-feedstock#42 (comment) ? |
@Tobias-Fischer It seems you had put it in the You can probably delete most of the things in the |
@rggjan the necessary dependencies for "running" are probably added automatically. For now, we don't have a way to specify the "build time" dependencies separately. When we started to slim down packages for run-time, this somewhat broke the "compilation time" dependencies. |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/vtk-feedstock/actions/runs/4405585347. |
Oh, I understand. Thanks a lot for the explanation. |
See conda-forge/conda-forge.github.io#1880 for more context the later comments are more important I think. |
Ok. This is weird. Now i believe that there is likely a missing run export. |
could we maybe try to fix this in offending library before merging this too eagerly. it seems that we are missing a dependency on https://github.com/conda-forge/llvmdev-feedstock/blob/main/recipe/meta.yaml#L77 |
Certainly this is the right way to go @hmaarrfk. Just trying to debug here what is going on .. |
great perfect. sorry, i just didn't want this to get "merged" accidentally. this "turbo" migration has caused alot of these little cleanups to happen. |
there is also a current proposal to move to llvm16, so i'm worried that it owuld break vtk :/ |
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Nice! Thank you for the back and forth |
Nicely done! 👏 |
This PR has been triggered in an effort to update jpeg_to_libjpeg_turbo.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4399242865, please use this URL for debugging.