source: Catch CondaHTTPError so mutliple urls get checked #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
reviewed
Jan 20, 2017
| @@ -59,6 +59,8 @@ def download_to_cache(metadata, config): | |||
| try: | |||
| print("Downloading %s" % url) | |||
| download(url, path) | |||
| except CondaHTTPError as e: | |||
| print("Error: %s" % str(e).strip(), file=sys.stderr) | |||
There was a problem hiding this comment.
would like these to be calls to logging rather than print, but I'm going to merge this as-is and refactor it next time I see it.
|
LGTM. All failures are known and part of the conda 4.3 stuff. Merging. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@msarahan, @kalefranz, please review. I'm not sure I need the old:
.. still, but I kept it anyway.
This is needed for R packages where each meta.yaml lists two URLs: