Pass WINDIR env var through on win #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yikes, changing base branch to 2.1.x was bad - I'll cherry-pick this back to the 2.1.x branch. Thanks. |
|
Do you mind signing our CLA? I can't merge your PR without it, unfortunately. |
|
Signed |
|
Great, thank you! Merging. |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was encountered when building a recipe for cx_Oracle. It was failing on the test stage because
import cx_Oracleresults in setuptoolspkg_resources.resource_filenamebeing called, which in turn has a call toos.environ['windir']on Windows.I guess that the
WINDIRenvironment variable is widely assumed to always be set on Windows, likeSYSTEMROOT.