Use symlinks while copying from file sources to improve perf. #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, master is in heavy construction. Should be more stable soon. Do you mind rebasing your work on the 2.1.x branch for now? I will get it in more quickly that way, and the tests there should all be passing. |
stuertz
force-pushed
the
filesource_as_symlink
branch
from
6ac9a12
to
f6349ca
Compare
|
I don't know what's up with the CI's. I'm just going to merge this and see how it does. Thanks @stuertz |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered why using file sources, no symlinks were used. Seems to be forgotten.
I tried running the very long running mentioned tests, but they fail before and after my change :-(
Running my local build worked fine for me with this change.