-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix index.json:"platform" in cross-platform builds #4124
Conversation
(Adding the actual fix and news entry after seeing the CI fail for the reported issue.) |
=================================== FAILURES ===================================
________________________ test_cross_info_index_platform ________________________
[gw1] darwin -- Python 3.8.3 /Users/runner/work/1/a/miniconda/bin/python
Traceback (most recent call last):
File "/Users/runner/work/1/s/tests/test_api_render.py", line 173, in test_cross_info_index_platform
assert metadata.config.host_platform == info_index['platform']
AssertionError: assert 'win' == 'osx'
- osx
+ win =================================== FAILURES ===================================
________________________ test_cross_info_index_platform ________________________
[gw0] linux -- Python 3.8.3 /usr/share/miniconda/bin/python
Traceback (most recent call last):
File "/home/vsts/work/1/s/tests/test_api_render.py", line 173, in test_cross_info_index_platform
assert metadata.config.host_platform == info_index['platform']
AssertionError: assert 'win' == 'linux'
- linux
+ win ================================== FAILURES ===================================
_______________________ test_cross_info_index_platform ________________________
[gw0] win32 -- Python 3.8.5 C:\Users\VssAdministrator\Miniconda3\python.exe
Traceback (most recent call last):
File "D:\a\1\s\tests\test_api_render.py", line 173, in test_cross_info_index_platform
assert metadata.config.host_platform == info_index['platform']
AssertionError: assert 'linux' == 'win'
- win
+ linux 🎉 (as intended). |
NB: Of course there are more hurdles for general purpose "Windows on Unix" building (linking, prefix replacement, ...). |
(Failures on macOS are unrelated, something storage-related or the like.) |
Thanks @mbargull |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
If we cross-build on different platforms and not just different architectures of the same platform, the
platform
key inindex.json
is not set to the target platform.refs: