Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE 🔎 Replace isolated mode with context.conda_exe #4628

Closed
2 tasks
kenodegard opened this issue Nov 14, 2022 · 1 comment
Closed
2 tasks

SPIKE 🔎 Replace isolated mode with context.conda_exe #4628

kenodegard opened this issue Nov 14, 2022 · 1 comment
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. spike issue is for doing research work or prototyping; outcome is optional and not required stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::tech-debt identifies or resolves some technical debt

Comments

@kenodegard
Copy link
Contributor

kenodegard commented Nov 14, 2022

Summary

We identified an issue with conda-build invoking the conda source code instead of the installed package when building the conda package:

@kenodegard, @travishathaway, and @jaimergp looked into this and settled on using the isolated mode, python -I -m conda:

After discussing with the conda-forge community in preparation for the conda 22.11.0 release it was determined that this change may have an outsized impact due to other side effects of the isolated mode.

Python arguments: -I, -E, -P, -s

python -I

python -E

python -P

Note
It appears we only want the -P argument, but unfortunately, this is only available starting with Python 3.11.

python -s

So it was decided to change the feature to use an opt-in flag instead:


Overall we feel that this opt-in feature adds unnecessary extra complexity to conda-build and would rather remove it. We need to investigate potential paths forward.

Timebox: Medium

Linked Issues & PRs

  • Is context.conda_exe a viable alternative to python [-I|-P] -m conda?
  • Identify all other instances in conda-build where context.conda_exe is used instead of python -m conda
@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt spike issue is for doing research work or prototyping; outcome is optional and not required backlog issue has been triaged but has not been earmarked for any upcoming release labels Nov 14, 2022
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Nov 16, 2023
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Dec 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. spike issue is for doing research work or prototyping; outcome is optional and not required stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::tech-debt identifies or resolves some technical debt
Projects
Archived in project
Development

No branches or pull requests

1 participant