Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the source when rendering if load_file_data is used #4817

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Mar 21, 2023

Description

Require the source to be downloaded and available if the load_file_data Jinja2 function is used in the recipe's meta.yaml.

closes #4807

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Add a test recipe which loads a pyproject.toml file from the source
directory.
If the load_file_data Jinja2 function is used in the meta.yaml text then
require the source to be available in order to render the recipe.

closes conda#4807
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 21, 2023
@jjhelmus jjhelmus closed this Apr 11, 2023
@jjhelmus jjhelmus reopened this Apr 11, 2023
Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll keeping an eye on the tests and rerunning the flaky ones

@jezdez jezdez merged commit f5051cb into conda:main Apr 12, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

load_file_data depends on textual occurrence of certain strings in meta.yaml
4 participants