Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entrypoint definition in pyproject.toml #5158

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix entrypoint definition in pyproject.toml #5158

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f68139f
Fix entrypoint definition in pyproject.toml
mbargull Jan 30, 2024
3d24132
Remove conda-index entrypoint
kenodegard Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ repository = "https://github.com/conda/conda-build"
changelog = "https://github.com/conda/conda-build/blob/main/CHANGELOG.md"

[project.scripts]
conda-build = "conda_build.cli.main_build:main"
conda-convert = "conda_build.cli.main_convert:main"
conda-develop = "conda_build.cli.main_develop:main"
conda-index = "conda_build.cli.main_index:main"
conda-inspect = "conda_build.cli.main_inspect:main"
conda-metapackage = "conda_build.cli.main_metapackage:main"
conda-render = "conda_build.cli.main_render:main"
conda-skeleton = "conda_build.cli.main_skeleton:main"
conda-debug = "conda_build.cli.main_debug:main"
conda-build = "conda_build.cli.main_build:execute"
conda-convert = "conda_build.cli.main_convert:execute"
conda-develop = "conda_build.cli.main_develop:execute"
conda-index = "conda_build.cli.main_index:execute"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how do we want to go about conda-index?
(The same line is also still in recipe/meta.yaml and thus needs adjusting there too.)

The cleanest way would be to

  1. add the conda-index script to the conda-index package,
  2. add a run_constrains to conda-index with conda-build>=24.1,
  3. release a new version of conda-index with those changes,
  4. add a that version as the lower bound of the conda-index dependency in conda-build.

... But IDK, if it's feasible to require a new conda-index release before the impending conda-build=24.1 release....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already planning on a conda-index 0.4.0 release to resolve this (and a circular dependency issue for Python 3.12 support)

conda-build should no longer be making any conda-index entrypoint scripts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not possible to do a new conda-index release beforehand, we may want to set this as conda-index = "conda_index.cli.cli"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for it still being in recipe/meta.yaml, that's a mistake we need to rectify

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already planning on a conda-index 0.4.0 release to resolve this (and a circular dependency issue for Python 3.12 support)

conda-build should no longer be making any conda-index entrypoint scripts

Ah, wasn't aware this is already cooking :).
For reference (for future self and others):

conda-inspect = "conda_build.cli.main_inspect:execute"
conda-metapackage = "conda_build.cli.main_metapackage:execute"
conda-render = "conda_build.cli.main_render:execute"
conda-skeleton = "conda_build.cli.main_skeleton:execute"
conda-debug = "conda_build.cli.main_debug:execute"

[project.entry-points."distutils.commands"]
bdist_conda = "conda_build.bdist_conda:bdist_conda"
Expand Down
Loading