Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use the RequestsTransport to access pypi #989

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

filmor
Copy link
Contributor

@filmor filmor commented Jun 1, 2016

This ensures that proxies from the environment are used even if they are not defined in the .condarc.

Fixes #550.

This ensures that proxies from the environment are used even if they are not defined in the `.condarc`.
@filmor filmor changed the title Always use the RequestsTransport. Always use the RequestsTransport to access pypi Jun 1, 2016
@msarahan
Copy link
Contributor

msarahan commented Jun 1, 2016

I'm not familiar with this code, nor really familiar with proxies. Can you describe what problem led you to this change? How does this affect proxy settings in condarc? What would it take to add a test for the functionality you desire?

@filmor
Copy link
Contributor Author

filmor commented Jun 1, 2016

Check issue #550. conda skeleton pypi (implemented in pypi.py) has code to use proxy servers (the mentioned RequestsTransport) correctly through the CondaSession object. However, this code is only invoked if the .condarc file contains the proxies entry, in particular, it skips the (otherwise working) $HTTP_PROXY etc. environment variables.

Regarding tests, I guess for those you would need a proxied environment on the CI servers, not configure the proxy server in .condarc but instead only in the environment and run conda skeleton pypi some-package there.

@msarahan
Copy link
Contributor

msarahan commented Jun 6, 2016

@filmor thanks for this. I don't fully grok all of this, but it looks like a good improvement to me. I'm going to merge it. Is it OK to ping you if I run across issues/concerns?

@msarahan msarahan merged commit 13790f4 into conda:master Jun 6, 2016
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conda skeleton ignores the proxy environment variables
2 participants