Fix test_s3_server failure
#12986
Merged
Fix test_s3_server failure
#12986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
Do you think it's related to a |
|
@jaimergp but our MinIO is frozen? conda/.github/workflows/tests.yml Line 32 in c691f72 However error message wise that would make sense |
|
oh! the MinIO version is frozen for Windows and macOS but not for Linux (which uses docker images): https://github.com/conda/conda/blob/main/.github/workflows/images.yml |
|
@jaimergp do you remember why the pin was originally added? #12524 (comment) (edit) never mind I found the source conda/conda-libmamba-solver#159 |
kenodegard
commented
Aug 10, 2023
kenodegard
changed the title
test_s3_server failuretest_s3_server failure
This was referenced Aug 10, 2023
Merged
travishathaway
approved these changes
Aug 10, 2023
jaimergp
approved these changes
Aug 10, 2023
3 tasks
beeankha
approved these changes
Aug 10, 2023
3 tasks
3 tasks
kenodegard
added a commit
to kenodegard/conda
that referenced
this pull request
Sep 11, 2023
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
3 tasks
jezdez
pushed a commit
that referenced
this pull request
Sep 11, 2023
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com> Fix `test_s3_server` failure (#12986)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix for #12989. A recent change to MinIO added validations to ensure the bucket name conforms to AWS S3 bucket naming rules (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html). The fix is to use a valid bucket name (dashes instead of underscores). Thanks go to @travishathaway for identifying the fix.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?