-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_s3_server
failure
#12986
Fix test_s3_server
failure
#12986
Conversation
Do you think it's related to a |
@jaimergp but our MinIO is frozen? conda/.github/workflows/tests.yml Line 32 in c691f72
However error message wise that would make sense |
oh! the MinIO version is frozen for Windows and macOS but not for Linux (which uses docker images): https://github.com/conda/conda/blob/main/.github/workflows/images.yml |
@jaimergp do you remember why the pin was originally added? #12524 (comment) (edit) never mind I found the source conda/conda-libmamba-solver#159 |
test_s3_server
failuretest_s3_server
failure
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com>
Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com> Fix `test_s3_server` failure (#12986)
Description
A fix for #12989. A recent change to MinIO added validations to ensure the bucket name conforms to AWS S3 bucket naming rules (https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucketnamingrules.html). The fix is to use a valid bucket name (dashes instead of underscores). Thanks go to @travishathaway for identifying the fix.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?Add / update outdated documentation?