Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context mocking for CondaSession test #13087

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Sep 11, 2023

Description

Discovered in #13062 (comment):

With the addition of new tests above the testing order was shuffled and exposed incorrect context mocking in this unrelated test, see https://github.com/conda/conda/actions/runs/6079217031/job/16498615642#step:8:909

...

The failure can be replicated on main with the following test order:

pytest \
    "tests/gateways/test_connection.py::test_get_session_with_channel_settings_no_handler" \
    "tests/gateways/test_jlap.py::test_jlap_fetch" \
    "tests/gateways/test_jlap.py::test_jlap_fetch_file" \
    "tests/gateways/test_jlap.py::test_download_and_hash" \
    "tests/gateways/test_jlap.py::test_jlap_cache_clock[True]"

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner September 11, 2023 18:20
@kenodegard kenodegard self-assigned this Sep 11, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 11, 2023
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of mock objects but LGTM

@kenodegard kenodegard enabled auto-merge (squash) September 11, 2023 19:10
@kenodegard kenodegard merged commit cc1dc07 into conda:main Sep 11, 2023
69 checks passed
@kenodegard kenodegard deleted the session-mock branch September 11, 2023 20:22
@jezdez jezdez mentioned this pull request Sep 26, 2023
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants