-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix archspec on windows #13641
Merged
Merged
Fix archspec on windows #13641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by fixing the check for non native subdirs and adding a lower bound on archspec
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Feb 29, 2024
CodSpeed Performance ReportMerging #13641 will not alter performanceComparing Summary
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
chenghlee
previously approved these changes
Mar 1, 2024
beeankha
reviewed
Mar 1, 2024
beeankha
previously approved these changes
Mar 1, 2024
jezdez
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would feel better if we'd add a test to verify the behavior for this
jezdez
approved these changes
Mar 5, 2024
beeankha
approved these changes
Mar 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by fixing the check for non native subdirs and adding a lower bound on archspec.
Fixes #13640
Description
Checklist - did you ...
news
directory (using the template) for the next release's release notes?