Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archspec on windows #13641

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Fix archspec on windows #13641

merged 7 commits into from
Mar 5, 2024

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Feb 29, 2024

by fixing the check for non native subdirs and adding a lower bound on archspec.

Fixes #13640

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

by fixing the check for non native subdirs and adding
a lower bound on archspec
@isuruf isuruf requested a review from a team as a code owner February 29, 2024 21:27
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 29, 2024
Copy link

codspeed-hq bot commented Feb 29, 2024

CodSpeed Performance Report

Merging #13641 will not alter performance

Comparing isuruf:archspec_win (1bb961a) with main (0f8fb58)

Summary

✅ 21 untouched benchmarks

@isuruf
Copy link
Contributor Author

isuruf commented Mar 1, 2024

pre-commit.ci autofix

@isuruf isuruf closed this Mar 1, 2024
@isuruf isuruf reopened this Mar 1, 2024
chenghlee
chenghlee previously approved these changes Mar 1, 2024
beeankha
beeankha previously approved these changes Mar 1, 2024
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would feel better if we'd add a test to verify the behavior for this

news/13641-archspec-windows Outdated Show resolved Hide resolved
@jezdez jezdez merged commit 38e56b9 into conda:main Mar 5, 2024
66 checks passed
@jezdez jezdez mentioned this pull request Mar 11, 2024
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

__archspec does not work on windows
6 participants